linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Oberparleiter <oberpar@linux.ibm.com>
To: Cixi Geng <gengcixi@gmail.com>,
	Greg KH <gregkh@linuxfoundation.org>,
	jslaby@suse.com, linux-serial@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Cixi Geng1 <cixi.geng1@unisoc.com>,
	Orson Zhai <orsonzhai@gmail.com>,
	zhang.lyra@gmail.com
Subject: Re: [PATCH V6] GCOV: Add config to check the preqequisites situation
Date: Thu, 23 Jul 2020 11:47:51 +0200	[thread overview]
Message-ID: <a5c4018c-a0fd-7855-1ee9-dc0c4e7251e7@linux.ibm.com> (raw)
In-Reply-To: <CAF12kFseC4MMbEUk6CgW=Hpz_Hg-+fjwbLZKFdPu0K_EGtcPDw@mail.gmail.com>

On 16.07.2020 14:38, Cixi Geng wrote:
> Hi All:
> Does this patch need more modification?

Yes. As it is now there's still a prompt for the prereq symbol. There
should be no prompt for this symbol in the config dialog.

[...]


>> diff --git a/kernel/gcov/Kconfig b/kernel/gcov/Kconfig
>> index 3941a9c48f83..f415c4aaf0ab 100644
>> --- a/kernel/gcov/Kconfig
>> +++ b/kernel/gcov/Kconfig
>> @@ -51,6 +51,16 @@ config GCOV_PROFILE_ALL
>>         larger and run slower. Also be sure to exclude files from profiling
>>         which are not linked to the kernel image to prevent linker errors.
>>
>> +config GCOV_PROFILE_PREREQS
>> +       bool "Profile Kernel for prereqs"
>> +       default y if GCOV_KERNEL && !COMPILE_TEST
>> +       help
>> +         This options activates profiling for the specified kernel modules.
>> +
>> +         When some modules need Gcov data, enable this config, then configure
>> +         with gcov on the corresponding modules,The directories or files of
>> +         these modules will be added profiling flags after kernel compile.
>> +

Replace the portion above with these lines:

config GCOV_PROFILE_PREREQS
        def_bool y if GCOV_KERNEL && !COMPILE_TEST



-- 
Peter Oberparleiter
Linux on Z Development - IBM Germany

      reply	other threads:[~2020-07-23  9:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-18 10:08 [PATCH V6] GCOV: Add config to check the preqequisites situation gengcixi
     [not found] ` <2fae67c7637f4e978cb54c3b96090788@BJMBX01.spreadtrum.com>
2020-07-16 12:38   ` Cixi Geng
2020-07-23  9:47     ` Peter Oberparleiter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a5c4018c-a0fd-7855-1ee9-dc0c4e7251e7@linux.ibm.com \
    --to=oberpar@linux.ibm.com \
    --cc=cixi.geng1@unisoc.com \
    --cc=gengcixi@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=orsonzhai@gmail.com \
    --cc=zhang.lyra@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).