From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 644EBC43441 for ; Wed, 21 Nov 2018 11:46:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3823F20831 for ; Wed, 21 Nov 2018 11:46:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3823F20831 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-sgx-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726612AbeKUWVB (ORCPT ); Wed, 21 Nov 2018 17:21:01 -0500 Received: from mga07.intel.com ([134.134.136.100]:51103 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726001AbeKUWVA (ORCPT ); Wed, 21 Nov 2018 17:21:00 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2018 03:46:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,261,1539673200"; d="scan'208";a="97969526" Received: from jsakkine-mobl1.tm.intel.com (HELO localhost) ([10.237.50.177]) by FMSMGA003.fm.intel.com with ESMTP; 21 Nov 2018 03:46:51 -0800 Date: Wed, 21 Nov 2018 13:46:50 +0200 From: Jarkko Sakkinen To: Sean Christopherson Cc: x86@kernel.org, platform-driver-x86@vger.kernel.org, linux-sgx@vger.kernel.org, dave.hansen@intel.com, nhorman@redhat.com, npmccallum@redhat.com, serge.ayoun@intel.com, shay.katz-zamir@intel.com, haitao.huang@intel.com, andriy.shevchenko@linux.intel.com, tglx@linutronix.de, kai.svahn@intel.com, Suresh Siddha , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Darren Hart , Andy Shevchenko , "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" Subject: Re: [PATCH v16 18/22] platform/x86: Intel SGX driver Message-ID: <20181121114650.GA1638@linux.intel.com> References: <20181106134758.10572-1-jarkko.sakkinen@linux.intel.com> <20181106134758.10572-19-jarkko.sakkinen@linux.intel.com> <1541522400.7839.48.camel@intel.com> <20181107163757.GB11509@linux.intel.com> <20181107180057.GB24807@linux.intel.com> <20181108144603.GA14072@linux.intel.com> <20181115200002.GA24006@linux.intel.com> <20181115200406.GA24299@linux.intel.com> <20181115201625.GA25953@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181115201625.GA25953@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-sgx-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sgx@vger.kernel.org On Thu, Nov 15, 2018 at 10:16:25PM +0200, Jarkko Sakkinen wrote: > This is how strongly think. I can go with VMAs for swapping *but* if > that is the route I would recommend using vm_mmap() instead of taking > pointer from user space. This way the way swapping is done can be always > changed. It will be a huge lock-in to do it otherwise. I digged out my old code and it should be easy to replace. Most of the issues were related to exit_mm(), which have been anyway sorted in the code base. I'll do it for v18. /Jarkko