From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BD10C43441 for ; Tue, 27 Nov 2018 16:36:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3399F21104 for ; Tue, 27 Nov 2018 16:36:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3399F21104 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-sgx-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731014AbeK1Den (ORCPT ); Tue, 27 Nov 2018 22:34:43 -0500 Received: from mga06.intel.com ([134.134.136.31]:47665 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726409AbeK1Dem (ORCPT ); Tue, 27 Nov 2018 22:34:42 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Nov 2018 08:36:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,287,1539673200"; d="scan'208";a="91116020" Received: from unknown (HELO localhost) ([10.24.8.96]) by fmsmga007.fm.intel.com with ESMTP; 27 Nov 2018 08:36:14 -0800 Date: Tue, 27 Nov 2018 08:36:14 -0800 From: Jarkko Sakkinen To: Jethro Beekman Cc: Andy Lutomirski , Andy Lutomirski , "Dr. Greg Wettstein" , X86 ML , Platform Driver , "linux-sgx@vger.kernel.org" , Dave Hansen , "Christopherson, Sean J" , "nhorman@redhat.com" , "npmccallum@redhat.com" , "Ayoun, Serge" , "shay.katz-zamir@intel.com" , "haitao.huang@linux.intel.com" , Andy Shevchenko , Thomas Gleixner , "Svahn, Kai" , "mark.shanahan@intel.com" , Suresh Siddha , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Darren Hart Subject: Re: [PATCH v17 18/23] platform/x86: Intel SGX driver Message-ID: <20181127163614.GA4170@linux.intel.com> References: <20181119161917.GF13298@linux.intel.com> <20181120120442.GA22172@linux.intel.com> <20181122111253.GA31150@wind.enjellic.com> <20181124172114.GB32210@linux.intel.com> <20181125145329.GA5777@linux.intel.com> <0669C300-02CB-4EA6-BF88-5C4B4DDAD4C7@amacapital.net> <20181126215145.GC868@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-sgx-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sgx@vger.kernel.org On Tue, Nov 27, 2018 at 07:46:48AM +0000, Jethro Beekman wrote: > On 2018-11-27 03:21, Jarkko Sakkinen wrote: > > BTW, off-topic from this but should we remove ENCLAVE from IOC names as > > they all concern enclaves anyway? Seems kind of redundant. I.e. > > > > SGX_IOC_ENCLAVE_CREATE -> SGX_IOC_CREATE > > SGX_IOC_ENCLAVE_ADD_PAGE -> SGX_IOC_ADD_PAGE > > SGX_IOC_ENCLAVE_INIT -> SGX_IOC_INIT > > Future ioctls might be added that deal with system-global SGX things? Like > an interface to communicate with the in-kernel LE or something. Yea, maybe better to keep it just in case. The names are not too long anyway. Then the new ioctl should be SGX_IOC_ENCLAVE_SET_ATTRIBUTE. /Jarkko