From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C29EC43387 for ; Mon, 17 Dec 2018 14:27:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D4F9320675 for ; Mon, 17 Dec 2018 14:27:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727666AbeLQO1X (ORCPT ); Mon, 17 Dec 2018 09:27:23 -0500 Received: from mga04.intel.com ([192.55.52.120]:56576 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726315AbeLQO1X (ORCPT ); Mon, 17 Dec 2018 09:27:23 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Dec 2018 06:27:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,365,1539673200"; d="scan'208";a="110108395" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.154]) by fmsmga008.fm.intel.com with ESMTP; 17 Dec 2018 06:27:22 -0800 Date: Mon, 17 Dec 2018 06:27:21 -0800 From: Sean Christopherson To: "Dr. Greg" Cc: Jarkko Sakkinen , Andy Lutomirski , Andy Lutomirski , X86 ML , Platform Driver , linux-sgx@vger.kernel.org, Dave Hansen , nhorman@redhat.com, npmccallum@redhat.com, "Ayoun, Serge" , shay.katz-zamir@intel.com, haitao.huang@linux.intel.com, Andy Shevchenko , Thomas Gleixner , "Svahn, Kai" , mark.shanahan@intel.com, Suresh Siddha , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Darren Hart , Andy Shevchenko , LKML , jethro@fortanix.com Subject: Re: [PATCH v17 18/23] platform/x86: Intel SGX driver Message-ID: <20181217142721.GA12491@linux.intel.com> References: <20181127085533.GA12247@wind.enjellic.com> <20181127164129.GB4170@linux.intel.com> <20181128104941.GA23077@wind.enjellic.com> <20181128192228.GC9023@linux.intel.com> <20181210104908.GA23132@wind.enjellic.com> <20181212180036.GC6333@linux.intel.com> <20181214235917.GA14049@wind.enjellic.com> <20181215000627.GA5799@linux.intel.com> <20181215232231.GA22773@wind.enjellic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181215232231.GA22773@wind.enjellic.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-sgx-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sgx@vger.kernel.org On Sat, Dec 15, 2018 at 05:22:31PM -0600, Dr. Greg wrote: > On Fri, Dec 14, 2018 at 04:06:27PM -0800, Sean Christopherson wrote: > > Good afternoon, I hope the weekend is going well for everyone. > > > On Fri, Dec 14, 2018 at 05:59:17PM -0600, Dr. Greg wrote: > > > On Wed, Dec 12, 2018 at 08:00:36PM +0200, Jarkko Sakkinen wrote: > > > > > > Good evening, I hope the week has gone well for everyone. > > > > > > > On Mon, Dec 10, 2018 at 04:49:08AM -0600, Dr. Greg wrote: > > > > > In the meantime, I wanted to confirm that your jarkko-sgx/master > > > > > branch contains the proposed driver that is headed upstream. > > > > > Before adding the SFLC patches we thought it best to run the > > > > > driver through some testing in order to verify that any problems > > > > > we generated where attributable to our work and not the base > > > > > driver. > > > > > > > > The master branch is by definition unstable at the moment i.e. it > > > > can sometimes (not often) contain unfinished changes. Use next for > > > > testing. I update next when I consider the master contents "stable > > > > enough". > > > > > > I noticed in the last day or so that you appeared to sync > > > jarkko-sgx/master with jarkko-sgx/next, so I checked out a local > > > branch against jarkko-sgx/next and ran it against our unit tests. > > > Based on what we are seeing the driver is still experiencing issues > > > with initialization of a non-trivial enclave. > > > master branch is broken, looks like the VMA code Jarkko is reworking is > > buggy. I should be able to help debug this next week. > > > > [ 504.149548] ------------[ cut here ]------------ > > [ 504.149550] kernel BUG at /home/sean/go/src/kernel.org/linux/mm/mmap.c:669! > > Rodger, dodger. > > Let us know when you think you have something working pushed up into > one of the branches and we will put it on the bench here in the lab > and see what our runtime is able to do with it. > > BTW, your new vDSO work appears to be shaping up well. Just out of > curiosity though, how are you testing and validating the new vDSO > based exception handler if it isn't possible to initialize and run an > enclave with the new driver? Cherry-pick the patches to a stable version of the driver, the vDSO code doesn't use any of the SGX APIs.