linux-sgx.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Jarkko Sakkinen" <jarkko@kernel.org>,
	"Bojun Zhu" <zhubojun.zbj@antgroup.com>,
	"Huang, Kai" <kai.huang@intel.com>,
	"linux-sgx@vger.kernel.org" <linux-sgx@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>
Cc: "刘双(轩屹)" <ls123674@antgroup.com>,
	"Chatre, Reinette" <reinette.chatre@intel.com>
Subject: Re: [RFC PATCH 1/1] x86/sgx: Explicitly give up the CPU in EDMM's ioctl() to avoid softlockup
Date: Wed, 24 Apr 2024 13:42:28 +0300	[thread overview]
Message-ID: <D0SAGP6DPKXF.2EHTXI9UH0HQ9@kernel.org> (raw)
In-Reply-To: <D0S5S2NL1N5P.3Q0SM01VIZBJX@kernel.org>

On Wed Apr 24, 2024 at 10:02 AM EEST, Jarkko Sakkinen wrote:
> On Wed Apr 24, 2024 at 9:46 AM EEST, Bojun Zhu wrote:
> > Based on the the discussion among you, Jarkko and Reinette,
> > I will keep the need_resched() and wrap the logic in using sgx_resched(),
> > as suggested by Jarkko.
>
> Sounds like a plan :-)

In sgx_ioc_enclave_add_pages() "if (!c)" check might cause possibly
some  confusion.

Reason for it is that in "transaction sense" the operation can
be only meaningfully restarted when no pages have not been added
as MRENCLAVE checksum cannot be reset.

BR, Jarkko

  reply	other threads:[~2024-04-24 10:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-23  9:25 [RFC PATCH 0/1] x86/sgx: Explicitly give up the CPU in EDMM's ioctl() to avoid softlockup 朱伯君(杰铭)
2024-04-23  9:25 ` [RFC PATCH 1/1] " 朱伯君(杰铭)
2024-04-23 11:50   ` Huang, Kai
2024-04-23 17:08     ` Reinette Chatre
2024-04-23 21:27       ` Jarkko Sakkinen
2024-04-23 22:41         ` Huang, Kai
2024-04-23 21:22     ` Jarkko Sakkinen
2024-04-24  6:46     ` Bojun Zhu
2024-04-24  7:02       ` Jarkko Sakkinen
2024-04-24 10:42         ` Jarkko Sakkinen [this message]
2024-04-24 11:50           ` Bojun Zhu
2024-04-24 17:44             ` Jarkko Sakkinen
2024-04-24 17:47               ` Jarkko Sakkinen
2024-04-23 21:10   ` Jarkko Sakkinen
2024-04-23 21:20     ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D0SAGP6DPKXF.2EHTXI9UH0HQ9@kernel.org \
    --to=jarkko@kernel.org \
    --cc=dave.hansen@linux.intel.com \
    --cc=kai.huang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sgx@vger.kernel.org \
    --cc=ls123674@antgroup.com \
    --cc=reinette.chatre@intel.com \
    --cc=zhubojun.zbj@antgroup.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).