From: Jarkko Sakkinen <jarkko@kernel.org>
To: "Dhanraj, Vijay" <vijay.dhanraj@intel.com>
Cc: "Chatre, Reinette" <reinette.chatre@intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
"linux-sgx@vger.kernel.org" <linux-sgx@vger.kernel.org>,
Shuah Khan <shuah@kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] selftests/sgx: Add SGX selftest augment_via_eaccept_long
Date: Thu, 25 Aug 2022 04:28:56 +0300 [thread overview]
Message-ID: <YwbQWL5SK0S+Nn00@kernel.org> (raw)
In-Reply-To: <DM8PR11MB55915BB75E3A6D266FC8D51DF66A9@DM8PR11MB5591.namprd11.prod.outlook.com>
On Wed, Aug 17, 2022 at 03:39:36PM +0000, Dhanraj, Vijay wrote:
>
>
> > -----Original Message-----
> > From: Jarkko Sakkinen <jarkko@kernel.org>
> > Sent: Wednesday, August 17, 2022 7:39 AM
> > To: Dhanraj, Vijay <vijay.dhanraj@intel.com>
> > Cc: Chatre, Reinette <reinette.chatre@intel.com>; Dave Hansen
> > <dave.hansen@linux.intel.com>; linux-sgx@vger.kernel.org; Shuah Khan
> > <shuah@kernel.org>; open list:KERNEL SELFTEST FRAMEWORK <linux-
> > kselftest@vger.kernel.org>; open list <linux-kernel@vger.kernel.org>
> > Subject: Re: [PATCH 2/2] selftests/sgx: Add SGX selftest
> > augment_via_eaccept_long
> >
> > On Wed, Aug 17, 2022 at 01:27:38AM +0000, Dhanraj, Vijay wrote:
> > > I think changing it to "int i" will cause a buffer overflow with
> > > edmm_size being 8GB.
> >
> > Hmm.. 'i' iterates segments. Amd I missing something?
> >
> > BR, Jarkko
>
> It is also used when iterating over pages to eaccept. This might cause an issue.
>
> for (i = 0; i < edmm_size; i += 4096) {
> eaccept_op.epc_addr = (uint64_t)(addr + i);
>
> Regards, Vijay
Ah got it, thanks.
BR, Jarkko
prev parent reply other threads:[~2022-08-25 1:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 23:38 [PATCH 1/2] x86/sgx: Handle VA page allocation failure for EAUG on PF Jarkko Sakkinen
2022-08-15 23:39 ` [PATCH 2/2] selftests/sgx: Add SGX selftest augment_via_eaccept_long Jarkko Sakkinen
2022-08-16 16:26 ` Reinette Chatre
2022-08-16 23:33 ` Jarkko Sakkinen
2022-08-16 23:37 ` Jarkko Sakkinen
2022-08-17 1:27 ` Dhanraj, Vijay
2022-08-17 4:35 ` Reinette Chatre
2022-08-17 14:44 ` Jarkko Sakkinen
2022-08-17 14:53 ` Jarkko Sakkinen
2022-08-17 15:43 ` Reinette Chatre
2022-08-17 16:36 ` Jarkko Sakkinen
2022-08-17 16:14 ` Dhanraj, Vijay
2022-08-17 14:38 ` Jarkko Sakkinen
2022-08-17 15:39 ` Dhanraj, Vijay
2022-08-25 1:28 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwbQWL5SK0S+Nn00@kernel.org \
--to=jarkko@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=shuah@kernel.org \
--cc=vijay.dhanraj@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).