linux-sgx.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Tim Gardner <tim.gardner@canonical.com>, dave.hansen@linux.intel.com
Cc: jarkko@kernel.org, shuah@kernel.org, linux-sgx@vger.kernel.org,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Subject: [PATCH 0/1] SGX self test fails
Date: Thu, 29 Apr 2021 11:55:23 -0700	[thread overview]
Message-ID: <c0725600-0a00-31dd-2ec3-20d4a86b33c5@intel.com> (raw)
In-Reply-To: <20210429183952.22797-1-tim.gardner@canonical.com>

On 4/29/21 11:39 AM, Tim Gardner wrote:
> I'm just starting my learning curve on SGX, so I don't know if I've missed
> some setup for the SGX device entries. After looking at arch/x86/kernel/cpu/sgx/driver.c
> I see that there is no mode value for either sgx_dev_enclave or sgx_dev_provision.
> 
> With this patch I can get the SGX self test to complete:
> 
> sudo ./test_sgx
> Warning: no execute permissions on device file /dev/sgx_enclave
> 0x0000000000000000 0x0000000000002000 0x03
> 0x0000000000002000 0x0000000000001000 0x05
> 0x0000000000003000 0x0000000000003000 0x03
> SUCCESS
> 
> Is the warning even necessary ?

Dang, I just added that warning.  I thought it was necessary, but I
guess not:

$ ls -l /dev/sgx_enclave
crw------- 1 dave dave 10, 125 Apr 28 11:32 /dev/sgx_enclave
$ ./test_sgx
0x0000000000000000 0x0000000000002000 0x03
0x0000000000002000 0x0000000000001000 0x05
0x0000000000003000 0x0000000000003000 0x03
SUCCESS

*But*, is that OK?  Should we be happily creating a PROT_EXEC mapping on
a ugo-x file?  Why were we respecting noexec on the filesystem but not
ugo-x on the file?


  parent reply	other threads:[~2021-04-29 18:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-29 18:39 Subject: [PATCH 0/1] SGX self test fails Tim Gardner
2021-04-29 18:39 ` [PATCH] selftests/sgx: Defeat execute permissions test Tim Gardner
2021-04-29 18:55 ` Dave Hansen [this message]
2021-04-30  9:25   ` Subject: [PATCH 0/1] SGX self test fails Dr. Greg
2021-05-03 15:41   ` Jarkko Sakkinen
2021-05-03 16:39     ` Dave Hansen
2021-05-03 22:37       ` Jarkko Sakkinen
2021-05-03 15:38 ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0725600-0a00-31dd-2ec3-20d4a86b33c5@intel.com \
    --to=dave.hansen@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=jarkko@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-sgx@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=tim.gardner@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).