From: Dave Jiang <dave.jiang@intel.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
Alexey Brodkin <abrodkin@synopsys.com>,
Vineet Gupta <vgupta@synopsys.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
Helge Deller <deller@gmx.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>, Dave Airlie <airlied@redhat.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Ben Skeggs <bskeggs@redhat.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Jiri Slaby <jirislaby@gmail.com>,
Nick Kossifidis <mickflemm@gmail.com>,
Luis Chamberlain <mcgrof@kernel.org>,
Kalle Valo <kvalo@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
Jon Mason <jdmason@kudzu.us>, Allen Hubbe <allenbh@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Thomas Gleixner <tglx@linutronix.de>,
linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-snps-arc@lists.infradead.org, linux-parisc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org,
dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
linux-media@vger.kernel.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-ntb@googlegroups.com,
virtualization@lists.linux-foundation.org,
linux-arch@vger.kernel.org
Subject: Re: [PATCH v2 3/9] ntb: intel: Constify ioreadX() iomem argument (as in generic implementation)
Date: Wed, 8 Jan 2020 13:29:08 -0700 [thread overview]
Message-ID: <64659f77-f807-7c8e-7595-731056c73bf4@intel.com> (raw)
In-Reply-To: <20200108200528.4614-4-krzk@kernel.org>
On 1/8/20 1:05 PM, Krzysztof Kozlowski wrote:
> The ioreadX() helpers have inconsistent interface. On some architectures
> void *__iomem address argument is a pointer to const, on some not.
>
> Implementations of ioreadX() do not modify the memory under the address
> so they can be converted to a "const" version for const-safety and
> consistency among architectures.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Dave Jiang <dave.jiang@intel.com>
>
> ---
>
> Changes since v1:
> 1. Add Geert's review.
> ---
> drivers/ntb/hw/intel/ntb_hw_gen1.c | 2 +-
> drivers/ntb/hw/intel/ntb_hw_gen3.h | 2 +-
> drivers/ntb/hw/intel/ntb_hw_intel.h | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/ntb/hw/intel/ntb_hw_gen1.c b/drivers/ntb/hw/intel/ntb_hw_gen1.c
> index bb57ec239029..9202502a9787 100644
> --- a/drivers/ntb/hw/intel/ntb_hw_gen1.c
> +++ b/drivers/ntb/hw/intel/ntb_hw_gen1.c
> @@ -1202,7 +1202,7 @@ int intel_ntb_peer_spad_write(struct ntb_dev *ntb, int pidx, int sidx,
> ndev->peer_reg->spad);
> }
>
> -static u64 xeon_db_ioread(void __iomem *mmio)
> +static u64 xeon_db_ioread(const void __iomem *mmio)
> {
> return (u64)ioread16(mmio);
> }
> diff --git a/drivers/ntb/hw/intel/ntb_hw_gen3.h b/drivers/ntb/hw/intel/ntb_hw_gen3.h
> index 75fb86ca27bb..d1455f24ec99 100644
> --- a/drivers/ntb/hw/intel/ntb_hw_gen3.h
> +++ b/drivers/ntb/hw/intel/ntb_hw_gen3.h
> @@ -91,7 +91,7 @@
> #define GEN3_DB_TOTAL_SHIFT 33
> #define GEN3_SPAD_COUNT 16
>
> -static inline u64 gen3_db_ioread(void __iomem *mmio)
> +static inline u64 gen3_db_ioread(const void __iomem *mmio)
> {
> return ioread64(mmio);
> }
> diff --git a/drivers/ntb/hw/intel/ntb_hw_intel.h b/drivers/ntb/hw/intel/ntb_hw_intel.h
> index e071e28bca3f..3c0a5a2da241 100644
> --- a/drivers/ntb/hw/intel/ntb_hw_intel.h
> +++ b/drivers/ntb/hw/intel/ntb_hw_intel.h
> @@ -102,7 +102,7 @@ struct intel_ntb_dev;
> struct intel_ntb_reg {
> int (*poll_link)(struct intel_ntb_dev *ndev);
> int (*link_is_up)(struct intel_ntb_dev *ndev);
> - u64 (*db_ioread)(void __iomem *mmio);
> + u64 (*db_ioread)(const void __iomem *mmio);
> void (*db_iowrite)(u64 db_bits, void __iomem *mmio);
> unsigned long ntb_ctl;
> resource_size_t db_size;
>
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
next prev parent reply other threads:[~2020-01-08 20:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 20:05 [PATCH v2 0/9] iomap: Constify ioreadX() iomem argument Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 1/9] iomap: Constify ioreadX() iomem argument (as in generic implementation) Krzysztof Kozlowski
2020-01-08 20:53 ` Arnd Bergmann
2020-01-09 12:00 ` Geert Uytterhoeven
2020-01-08 20:05 ` [PATCH v2 2/9] net: wireless: rtl818x: " Krzysztof Kozlowski
2020-01-26 15:11 ` Kalle Valo
2020-01-08 20:05 ` [PATCH v2 3/9] ntb: intel: " Krzysztof Kozlowski
2020-01-08 20:29 ` Dave Jiang [this message]
2020-01-08 20:05 ` [PATCH v2 4/9] virtio: pci: " Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 5/9] arc: " Krzysztof Kozlowski
2020-01-09 6:59 ` Alexey Brodkin
2020-01-08 20:05 ` [PATCH v2 6/9] drm/mgag200: " Krzysztof Kozlowski
2020-01-09 6:04 ` Thomas Zimmermann
2020-01-08 20:05 ` [PATCH v2 7/9] drm/nouveau: " Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 8/9] media: fsl-viu: " Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 9/9] net: wireless: ath5k: " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64659f77-f807-7c8e-7595-731056c73bf4@intel.com \
--to=dave.jiang@intel.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=abrodkin@synopsys.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=allenbh@gmail.com \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=bskeggs@redhat.com \
--cc=dalias@libc.org \
--cc=daniel@ffwll.ch \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert+renesas@glider.be \
--cc=ink@jurassic.park.msu.ru \
--cc=jasowang@redhat.com \
--cc=jdmason@kudzu.us \
--cc=jirislaby@gmail.com \
--cc=krzk@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mattst88@gmail.com \
--cc=mcgrof@kernel.org \
--cc=mchehab@kernel.org \
--cc=mickflemm@gmail.com \
--cc=mpe@ellerman.id.au \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=paulus@samba.org \
--cc=rth@twiddle.net \
--cc=tglx@linutronix.de \
--cc=vgupta@synopsys.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).