From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>,
"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>
Cc: "linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>
Subject: Re: [PATCH v6 06/13] ARC: hardware floating point support
Date: Fri, 5 Jun 2020 14:22:17 -0300 [thread overview]
Message-ID: <c937b3b9-5872-4ee0-c189-2924dddf17df@linaro.org> (raw)
In-Reply-To: <214245c7-c89b-22bf-25db-fc9148ac5f92@synopsys.com>
On 05/06/2020 01:44, Vineet Gupta wrote:
> On 5/29/20 4:50 PM, Vineet Gupta via Libc-alpha wrote:
>>>> Although this code follow other architectures, I think it woudl be better
>>>> to move forward a macro that emulates function calls and use proper
>>>> static inline function instead for _FPU_* (as for get-rounding-mode.h).
>>> OK. do you have a preference for names, existing upper case names OK ?
>> Something like below ?
>>
>> +# define _FPU_FPSR_FWE 0x80000000
>> +
>> -# define _FPU_GETCW(cw) __asm__ volatile ("lr %0, [0x300]" : "=r" (cw))
>> -# define _FPU_SETCW(cw) __asm__ volatile ("sr %0, [0x300]" : : "r" (cw))
>> +static inline unsigned int arc_fpu_getcw(void)
>> +{
>> + unsigned int cw;
>> + __asm__ volatile ("lr %0, [0x300]" : "=r" (cw));
>> + return cw;
>> +}
>> +
>> +static inline void arc_fpu_setcw(unsigned int cw)
>> +{
>> + __asm__ volatile ("sr %0, [0x300]" : : "r" (cw));
>> +}
>
> It seems there is more discussiosn to be had here. Can we just punt on this
> specific item and keep the status quo macros please. We are heading towards july
> and I'd rather have the port go in this cycle !
I don't have a strong opinion here, it was more a suggestion. It seems
to follow other architectures, although at least alpha does not
provide the _FPU_GETCW macro. Another option would to just
move this definition to an internal header as well.
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
next prev parent reply other threads:[~2020-06-05 17:22 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 1:41 [PATCH v6 00/13] glibc port to ARC processors Vineet Gupta
2020-04-23 1:41 ` [PATCH v6 01/13] ARC: ABI Implementation Vineet Gupta
[not found] ` <88508d10-2d29-026a-bb54-ad607154ab87@linaro.org>
2020-05-27 22:15 ` Vineet Gupta
2020-05-29 13:56 ` Adhemerval Zanella
[not found] ` <a56a35d4-3e9e-9a88-4be5-8553d5f11ad3@synopsys.com>
[not found] ` <87mu5jxkv7.fsf@oldenburg2.str.redhat.com>
2020-06-04 19:01 ` Vineet Gupta
2020-06-04 23:56 ` Vineet Gupta
2020-04-23 1:41 ` [PATCH v6 02/13] ARC: startup and dynamic linking code Vineet Gupta
[not found] ` <17957ee6-2bc1-f43b-f184-f0703ba2765f@linaro.org>
2020-05-28 1:14 ` Vineet Gupta
2020-04-23 1:41 ` [PATCH v6 03/13] ARC: Thread Local Storage support Vineet Gupta
[not found] ` <4f7a67fb-6f96-57e6-b827-d1ab5dd6733f@linaro.org>
2020-05-28 1:36 ` Vineet Gupta
2020-06-01 18:53 ` Adhemerval Zanella
2020-04-23 1:41 ` [PATCH v6 04/13] ARC: Atomics and Locking primitives Vineet Gupta
[not found] ` <03f4a9b3-b1ca-90fa-0b6a-609a3135267d@linaro.org>
2020-04-24 7:23 ` Vineet Gupta
[not found] ` <20200427215938.14136-1-vgupta@synopsys.com>
2020-04-27 22:13 ` [PATCH] semaphore: consolidate arch headers into a generic one Vineet Gupta
[not found] ` <ac93c301-36d3-b20a-d31c-50c1f3264c68@linaro.org>
2020-05-05 22:59 ` Vineet Gupta
2020-05-08 13:32 ` Adhemerval Zanella
2020-04-23 1:41 ` [PATCH v6 05/13] ARC: math soft float support Vineet Gupta
2020-04-23 1:41 ` [PATCH v6 06/13] ARC: hardware floating point support Vineet Gupta
2020-05-29 14:12 ` Adhemerval Zanella
2020-05-29 22:28 ` Vineet Gupta
2020-05-29 23:50 ` Vineet Gupta
2020-06-02 17:51 ` Joseph Myers
[not found] ` <07887c48-7e07-9f89-035d-3f336a16f2da@synopsys.com>
2020-06-02 18:13 ` static inline math functions (was Re: [PATCH v6 06/13] ARC: hardware floating point support) Joseph Myers
2020-06-02 18:35 ` Adhemerval Zanella
2020-06-05 4:44 ` [PATCH v6 06/13] ARC: hardware floating point support Vineet Gupta
2020-06-05 17:22 ` Adhemerval Zanella [this message]
2020-06-02 17:48 ` Joseph Myers
2020-04-23 1:41 ` [PATCH v6 07/13] ARC: Linux Syscall Interface Vineet Gupta
2020-05-29 16:49 ` Adhemerval Zanella
2020-05-30 2:02 ` Vineet Gupta
2020-06-03 19:46 ` Vineet Gupta
2020-06-03 20:04 ` Adhemerval Zanella
2020-06-03 20:17 ` Vineet Gupta
2020-06-04 11:06 ` Adhemerval Zanella
2020-04-23 1:41 ` [PATCH v6 08/13] ARC: Linux ABI Vineet Gupta
2020-04-23 1:41 ` [PATCH v6 09/13] ARC: Linux Startup and Dynamic Loading Vineet Gupta
2020-04-23 1:41 ` [PATCH v6 10/13] ARC: ABI lists Vineet Gupta
2020-04-23 1:41 ` [PATCH v6 11/13] ARC: Build Infrastructure Vineet Gupta
2020-06-03 19:58 ` Adhemerval Zanella
2020-06-04 15:25 ` Vineet Gupta
2020-06-04 17:05 ` Adhemerval Zanella
2020-06-08 4:18 ` Vineet Gupta
2020-04-23 1:41 ` [PATCH v6 12/13] build-many-glibcs.py: Enable ARC builds Vineet Gupta
2020-04-23 1:41 ` [PATCH v6 13/13] Documentation for ARC port Vineet Gupta
2020-05-04 21:21 ` [PATCH v6 00/13] glibc port to ARC processors Vineet Gupta
2020-05-15 0:45 ` Vineet Gupta
2020-05-27 1:49 ` Vineet Gupta
[not found] ` <d7f1176c-87c6-90c6-161c-4705a47837ea@linaro.org>
2020-05-27 18:38 ` Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c937b3b9-5872-4ee0-c189-2924dddf17df@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=Vineet.Gupta1@synopsys.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).