linux-sparse.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: linux-sparse@vger.kernel.org
Cc: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Subject: [PATCH 1/9] change testing of signed compares against SMIN or SMAX
Date: Wed, 10 Mar 2021 22:49:42 +0100	[thread overview]
Message-ID: <20210310214950.84192-2-luc.vanoostenryck@gmail.com> (raw)
In-Reply-To: <20210310214950.84192-1-luc.vanoostenryck@gmail.com>

These tests are written by testing if the comparisons are equal
to their expected value: 0 or 1. So, a compare of a compare
but such compares of compare have their own simplification
which defeats what's tested here.

So, rewrite the test to avoid such compares of compare.

Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
 validation/optim/cmps-minmax.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/validation/optim/cmps-minmax.c b/validation/optim/cmps-minmax.c
index 5802cdbcafd1..0b1a0a099d7d 100644
--- a/validation/optim/cmps-minmax.c
+++ b/validation/optim/cmps-minmax.c
@@ -1,11 +1,11 @@
 #define SMAX __INT_MAX__
 #define SMIN (-__INT_MAX__-1)
 
-int lt_smin(int a) { return (a <  SMIN) == 0; }
-int le_smax(int a) { return (a <= SMAX) == 1; }
+int lt_smin(int a) { return (a <  SMIN) + 1; }
+int le_smax(int a) { return (a <= SMAX) + 0; }
 
-int ge_smin(int a) { return (a >= SMIN) == 1; }
-int gt_smax(int a) { return (a >  SMAX) == 0; }
+int ge_smin(int a) { return (a >= SMIN) + 0; }
+int gt_smax(int a) { return (a >  SMAX) + 1; }
 
 /*
  * check-name: cmps-minmax
-- 
2.30.0


  reply	other threads:[~2021-03-10 22:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-10 21:49 [PATCH 0/9] simplify CMP(AND(x,M), C) and CMP(OR(x,M), C) Luc Van Oostenryck
2021-03-10 21:49 ` Luc Van Oostenryck [this message]
2021-03-10 21:49 ` [PATCH 2/9] add testcases for constant compares against AND/OR Luc Van Oostenryck
2021-03-10 21:49 ` [PATCH 3/9] simplify (x & M) cmps C Luc Van Oostenryck
2021-03-10 21:49 ` [PATCH 4/9] simplify (x & M) cmpu C Luc Van Oostenryck
2021-03-10 21:49 ` [PATCH 5/9] simplify (x & M) cmps 0 Luc Van Oostenryck
2021-03-10 21:49 ` [PATCH 6/9] simplify (x & M) {==,!=} C Luc Van Oostenryck
2021-03-10 21:49 ` [PATCH 7/9] simplify (x | " Luc Van Oostenryck
2021-03-10 21:49 ` [PATCH 8/9] simplify (x | M) cmps C Luc Van Oostenryck
2021-03-10 21:49 ` [PATCH 9/9] simplify (x | M) cmpu C Luc Van Oostenryck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210310214950.84192-2-luc.vanoostenryck@gmail.com \
    --to=luc.vanoostenryck@gmail.com \
    --cc=linux-sparse@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).