From: Luc Van Oostenryck <lucvoo@kernel.org>
To: linux-sparse@vger.kernel.org
Cc: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Subject: [PATCH 3/5] scheck: constants are untyped
Date: Thu, 29 Jul 2021 23:20:52 +0200 [thread overview]
Message-ID: <20210729212054.34327-4-lucvoo@kernel.org> (raw)
In-Reply-To: <20210729212054.34327-1-lucvoo@kernel.org>
From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
in sparse, constants (PSEUDO_VALs) are not typed, so the same pseudo
can be used to represent 1-bit 0, 8-bit 0, 16-bit 0, ...
That's incompatible with the bit vectors used here, so we can't associate
a PSEUDO_VAL with its own bitvector like it's done for PSEUDO_REGs.
A fresh one is needed for each occurrence (we could use a small table
but won't bother).
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
scheck.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/scheck.c b/scheck.c
index d3ebddd6c2f5..5e2b60abb163 100644
--- a/scheck.c
+++ b/scheck.c
@@ -53,15 +53,14 @@ static BoolectorNode *mkvar(Btor *btor, BoolectorSort s, pseudo_t pseudo)
static char buff[33];
BoolectorNode *n;
- if (pseudo->priv)
- return pseudo->priv;
-
switch (pseudo->type) {
case PSEUDO_VAL:
sprintf(buff, "%llx", pseudo->value);
return boolector_consth(btor, s, buff);
case PSEUDO_ARG:
case PSEUDO_REG:
+ if (pseudo->priv)
+ return pseudo->priv;
n = boolector_var(btor, s, show_pseudo(pseudo));
break;
default:
--
2.32.0
next prev parent reply other threads:[~2021-07-29 21:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 21:20 [PATCH 0/5] small fixes for the symbolic checker Luc Van Oostenryck
2021-07-29 21:20 ` [PATCH 1/5] scheck: better diagnostic for unsupported instructions Luc Van Oostenryck
2021-07-29 21:20 ` [PATCH 2/5] scheck: ignore OP_NOP & friends Luc Van Oostenryck
2021-07-29 21:20 ` Luc Van Oostenryck [this message]
2021-07-29 21:20 ` [PATCH 4/5] scheck: mkvar() with target or input type Luc Van Oostenryck
2021-07-29 21:20 ` [PATCH 5/5] scheck: fix type of operands in casts Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210729212054.34327-4-lucvoo@kernel.org \
--to=lucvoo@kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=luc.vanoostenryck@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).