From: "Guido Günther" <agx@sigxcpu.org>
To: kernel test robot <rong.a.chen@intel.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
kbuild-all@lists.01.org, linux-sparse@vger.kernel.org
Subject: Re: [PATCH v2 2/4] usb: typec: tps6598x: Add trace event for status register
Date: Sun, 14 Feb 2021 18:06:15 +0100 [thread overview]
Message-ID: <YClYh7pqDlbXy8qh@bogon.m.sigxcpu.org> (raw)
In-Reply-To: <20210213031237.GP219708@shao2-debian>
Hi ,
On Sat, Feb 13, 2021 at 11:12:37AM +0800, kernel test robot wrote:
> Hi "Guido,
>
> I love your patch! Perhaps something to improve:
>
> [auto build test WARNING on usb/usb-testing]
> [also build test WARNING on v5.11-rc7 next-20210211]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/0day-ci/linux/commits/Guido-G-nther/usb-typec-tps6598x-Add-IRQ-flag-and-register-tracing/20210212-200855
> base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
> config: openrisc-randconfig-s032-20210209 (attached as .config)
> compiler: or1k-linux-gcc (GCC) 9.3.0
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # apt-get install sparse
> # sparse version: v0.6.3-215-g0fb77bb6-dirty
> # https://github.com/0day-ci/linux/commit/ba45e1d5e1fd25b6aed8724106e6c7d5adef7a20
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review Guido-G-nther/usb-typec-tps6598x-Add-IRQ-flag-and-register-tracing/20210212-200855
> git checkout ba45e1d5e1fd25b6aed8724106e6c7d5adef7a20
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=openrisc
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <rong.a.chen@intel.com>
>
>
> "sparse warnings: (new ones prefixed by >>)"
> drivers/usb/typec/tps6598x.c: note: in included file (through include/trace/trace_events.h, include/trace/define_trace.h, drivers/usb/typec/tps6598x_trace.h):
> >> drivers/usb/typec/./tps6598x_trace.h:157:1: sparse: sparse: too long token expansion
>
I looked around but didn't find any hints how to fix this. Any pointers
I missed (added the sparse list to cc:)?
Cheers,
-- Guido
> vim +157 drivers/usb/typec/./tps6598x_trace.h
>
> c90c0282e4ce33 Guido Günther 2021-02-12 156
> ba45e1d5e1fd25 Guido Günther 2021-02-12 @157 TRACE_EVENT(tps6598x_status,
> ba45e1d5e1fd25 Guido Günther 2021-02-12 158 TP_PROTO(u32 status),
> ba45e1d5e1fd25 Guido Günther 2021-02-12 159 TP_ARGS(status),
> ba45e1d5e1fd25 Guido Günther 2021-02-12 160
> ba45e1d5e1fd25 Guido Günther 2021-02-12 161 TP_STRUCT__entry(
> ba45e1d5e1fd25 Guido Günther 2021-02-12 162 __field(u32, status)
> ba45e1d5e1fd25 Guido Günther 2021-02-12 163 ),
> ba45e1d5e1fd25 Guido Günther 2021-02-12 164
> ba45e1d5e1fd25 Guido Günther 2021-02-12 165 TP_fast_assign(
> ba45e1d5e1fd25 Guido Günther 2021-02-12 166 __entry->status = status;
> ba45e1d5e1fd25 Guido Günther 2021-02-12 167 ),
> ba45e1d5e1fd25 Guido Günther 2021-02-12 168
> ba45e1d5e1fd25 Guido Günther 2021-02-12 169 TP_printk("conn: %s, pp_5v0: %s, pp_hv: %s, pp_ext: %s, pp_cable: %s, "
> ba45e1d5e1fd25 Guido Günther 2021-02-12 170 "pwr-src: %s, vbus: %s, usb-host: %s, legacy: %s, flags: %s",
> ba45e1d5e1fd25 Guido Günther 2021-02-12 171 show_status_conn_state(__entry->status),
> ba45e1d5e1fd25 Guido Günther 2021-02-12 172 show_status_pp_switch_state(TPS_STATUS_PP_5V0_SWITCH(__entry->status)),
> ba45e1d5e1fd25 Guido Günther 2021-02-12 173 show_status_pp_switch_state(TPS_STATUS_PP_HV_SWITCH(__entry->status)),
> ba45e1d5e1fd25 Guido Günther 2021-02-12 174 show_status_pp_switch_state(TPS_STATUS_PP_EXT_SWITCH(__entry->status)),
> ba45e1d5e1fd25 Guido Günther 2021-02-12 175 show_status_pp_switch_state(TPS_STATUS_PP_CABLE_SWITCH(__entry->status)),
> ba45e1d5e1fd25 Guido Günther 2021-02-12 176 show_status_power_sources(__entry->status),
> ba45e1d5e1fd25 Guido Günther 2021-02-12 177 show_status_vbus_status(__entry->status),
> ba45e1d5e1fd25 Guido Günther 2021-02-12 178 show_status_usb_host_present(__entry->status),
> ba45e1d5e1fd25 Guido Günther 2021-02-12 179 show_status_legacy(__entry->status),
> ba45e1d5e1fd25 Guido Günther 2021-02-12 180 show_status_flags(__entry->status)
> ba45e1d5e1fd25 Guido Günther 2021-02-12 181 )
> ba45e1d5e1fd25 Guido Günther 2021-02-12 182 );
> ba45e1d5e1fd25 Guido Günther 2021-02-12 183
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
> _______________________________________________
> kbuild mailing list -- kbuild@lists.01.org
> To unsubscribe send an email to kbuild-leave@lists.01.org
next parent reply other threads:[~2021-02-14 17:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <651ac50b9ff6ed3db8cab9f176514900f6a02a0c.1613131413.git.agx@sigxcpu.org>
[not found] ` <20210213031237.GP219708@shao2-debian>
2021-02-14 17:06 ` Guido Günther [this message]
2021-02-14 18:31 ` [PATCH v2 2/4] usb: typec: tps6598x: Add trace event for status register Ramsay Jones
2021-02-14 19:00 ` Linus Torvalds
2021-02-14 19:07 ` Linus Torvalds
2021-02-14 19:31 ` Ramsay Jones
2021-02-14 20:41 ` Luc Van Oostenryck
2021-02-15 11:32 ` Guido Günther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YClYh7pqDlbXy8qh@bogon.m.sigxcpu.org \
--to=agx@sigxcpu.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rong.a.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).