From: Stephen Boyd <swboyd@chromium.org>
To: Doug Anderson <dianders@chromium.org>
Cc: alokc@codeaurora.org, Mark Brown <broonie@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-spi <linux-spi@vger.kernel.org>,
Matthias Kaehlcke <mka@chromium.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Girish Mahadevan <girishm@codeaurora.org>,
Dilip Kota <dkota@codeaurora.org>
Subject: Re: [PATCH V5 3/3] spi: spi-geni-qcom: Add SPI driver support for GENI based QUP
Date: Tue, 09 Oct 2018 09:12:06 -0700 [thread overview]
Message-ID: <153910152600.119890.14820584405992384926@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <CAD=FV=XnYucy4JmgATrB89RYHTbzRC_GaouaRjHAocD4-H0ncg@mail.gmail.com>
Quoting Doug Anderson (2018-10-08 16:52:36)
> Hi,
>
> On Mon, Oct 8, 2018 at 4:43 PM Stephen Boyd <swboyd@chromium.org> wrote:
> > > + mas->irq = platform_get_irq(pdev, 0);
> > > + if (mas->irq < 0) {
> > > + ret = mas->irq;
> > > + dev_err(&pdev->dev, "Err getting IRQ %d\n", ret);
> > > + goto spi_geni_probe_runtime_disable;
> > > + }
> >
> > Nitpick: If you got the irq earlier before allocating anything then nothing has
> > to be put on failure path.
>
> I think this might have been in response to previous feedback from you
> suggesting that we should get the irq as late as possible. Ah, here
> ya go:
>
> https://lkml.kernel.org/r/153780767551.119890.9339380838620508307@swboyd.mtv.corp.google.com
Yes I suggested we register for the irq as last as possible, but I
didn't suggest calling platform_get_irq() this late. It could be called
earlier so that if there isn't any irq then nothing to do besides return
failure.
next prev parent reply other threads:[~2018-10-09 16:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 13:44 [PATCH V5 0/3] spi-geni-qcom: QUP SPI GENI driver and SPI device tree bindings Alok Chauhan
2018-10-03 13:44 ` [PATCH V5 1/3] dt-bindings: soc: qcom: Remove SPI controller maximum frequency binding Alok Chauhan
2018-10-03 13:44 ` [PATCH V5 2/3] dt-bindings: soc: qcom: GENI SE SPI controller device tree binding Alok Chauhan
2018-10-03 13:44 ` [PATCH V5 3/3] spi: spi-geni-qcom: Add SPI driver support for GENI based QUP Alok Chauhan
2018-10-03 17:46 ` Doug Anderson
2018-10-08 23:43 ` Stephen Boyd
2018-10-08 23:52 ` Doug Anderson
2018-10-09 16:12 ` Stephen Boyd [this message]
2018-10-09 17:48 ` Doug Anderson
2018-10-09 19:45 ` Stephen Boyd
2018-10-09 21:18 ` Doug Anderson
2018-10-10 1:22 ` Stephen Boyd
2018-10-11 7:13 ` alokc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=153910152600.119890.14820584405992384926@swboyd.mtv.corp.google.com \
--to=swboyd@chromium.org \
--cc=alokc@codeaurora.org \
--cc=broonie@kernel.org \
--cc=dianders@chromium.org \
--cc=dkota@codeaurora.org \
--cc=girishm@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mka@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).