From: Tiezhu Yang <yangtiezhu@loongson.cn>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 3/4] spi: spidev_test: Use perror() only if errno is not 0
Date: Thu, 13 Feb 2020 12:16:07 +0800 [thread overview]
Message-ID: <1581567368-8055-3-git-send-email-yangtiezhu@loongson.cn> (raw)
In-Reply-To: <1581567368-8055-1-git-send-email-yangtiezhu@loongson.cn>
It is better to use perror() only if errno is not 0, it should use printf()
when errno is 0, otherwise there exists redudant ": Success".
E.g. without this patch:
$ ./spidev_test -p 1234 --input test.bin
only one of -p and --input may be selected: Success
Aborted (core dumped)
With this patch:
$ ./spidev_test -p 1234 --input test.bin
only one of -p and --input may be selected
Aborted (core dumped)
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
tools/spi/spidev_test.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tools/spi/spidev_test.c b/tools/spi/spidev_test.c
index 5866178..27967dd 100644
--- a/tools/spi/spidev_test.c
+++ b/tools/spi/spidev_test.c
@@ -13,6 +13,7 @@
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
+#include <errno.h>
#include <getopt.h>
#include <fcntl.h>
#include <time.h>
@@ -26,7 +27,11 @@
static void pabort(const char *s)
{
- perror(s);
+ if (errno != 0)
+ perror(s);
+ else
+ printf("%s\n", s);
+
abort();
}
--
1.8.3.1
next prev parent reply other threads:[~2020-02-13 4:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 4:16 [PATCH 1/4] spi: spidev_test: Remove break after exit statement Tiezhu Yang
2020-02-13 4:16 ` [PATCH 2/4] spi: spidev_test: Check input_tx and input_file first after parse options Tiezhu Yang
[not found] ` <1581567368-8055-2-git-send-email-yangtiezhu-cXZgJK919ebM1kAEIRd3EQ@public.gmane.org>
2020-02-13 8:26 ` Geert Uytterhoeven
2020-02-13 13:32 ` Applied "spi: spidev_test: Check input_tx and input_file first after parse options" to the spi tree Mark Brown
2020-02-13 4:16 ` Tiezhu Yang [this message]
[not found] ` <1581567368-8055-3-git-send-email-yangtiezhu-cXZgJK919ebM1kAEIRd3EQ@public.gmane.org>
2020-02-13 8:27 ` [PATCH 3/4] spi: spidev_test: Use perror() only if errno is not 0 Geert Uytterhoeven
2020-02-13 13:32 ` Applied "spi: spidev_test: Use perror() only if errno is not 0" to the spi tree Mark Brown
[not found] ` <1581567368-8055-1-git-send-email-yangtiezhu-cXZgJK919ebM1kAEIRd3EQ@public.gmane.org>
2020-02-13 4:16 ` [PATCH 4/4] spi: spidev_test: Remove the whole "include" directory when make clean Tiezhu Yang
[not found] ` <1581567368-8055-4-git-send-email-yangtiezhu-cXZgJK919ebM1kAEIRd3EQ@public.gmane.org>
2020-02-13 13:32 ` Applied "spi: spidev_test: Remove the whole "include" directory when make clean" to the spi tree Mark Brown
2020-02-13 8:23 ` [PATCH 1/4] spi: spidev_test: Remove break after exit statement Geert Uytterhoeven
2020-02-13 13:32 ` Applied "spi: spidev_test: Remove break after exit statement" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1581567368-8055-3-git-send-email-yangtiezhu@loongson.cn \
--to=yangtiezhu@loongson.cn \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).