From: Jay Fang <f.fangjian@huawei.com>
To: <broonie@kernel.org>, <linux-spi@vger.kernel.org>
Cc: <sfr@canb.auug.org.au>, <huangdaode@huawei.com>, <linuxarm@huawei.com>
Subject: [PATCH-next] spi: hisi-kunpeng: Fix Woverflow warning on conversion
Date: Wed, 7 Apr 2021 10:31:00 +0800 [thread overview]
Message-ID: <1617762660-54681-1-git-send-email-f.fangjian@huawei.com> (raw)
Fix warning Woverflow on type conversion reported on x86_64:
drivers/spi/spi-hisi-kunpeng.c:361:9: warning: conversion from 'long unsigned int' to 'u32'
{aka 'unsigned int'} changes value from '18446744073709551600' to '4294967280' [-Woverflow]
The registers are 32 bit, so fix by casting to u32.
Fixes: c770d8631e18 ("spi: Add HiSilicon SPI Controller Driver for Kunpeng SoCs")
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Jay Fang <f.fangjian@huawei.com>
---
drivers/spi/spi-hisi-kunpeng.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-hisi-kunpeng.c b/drivers/spi/spi-hisi-kunpeng.c
index abc0cd5..3f986ba 100644
--- a/drivers/spi/spi-hisi-kunpeng.c
+++ b/drivers/spi/spi-hisi-kunpeng.c
@@ -358,7 +358,7 @@ static int hisi_spi_transfer_one(struct spi_controller *master,
smp_mb();
/* Enable all interrupts and the controller */
- writel(~IMR_MASK, hs->regs + HISI_SPI_IMR);
+ writel(~(u32)IMR_MASK, hs->regs + HISI_SPI_IMR);
writel(1, hs->regs + HISI_SPI_ENR);
return 1;
--
2.7.4
next reply other threads:[~2021-04-07 2:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 2:31 Jay Fang [this message]
2021-04-07 20:26 ` [PATCH-next] spi: hisi-kunpeng: Fix Woverflow warning on conversion Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1617762660-54681-1-git-send-email-f.fangjian@huawei.com \
--to=f.fangjian@huawei.com \
--cc=broonie@kernel.org \
--cc=huangdaode@huawei.com \
--cc=linux-spi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).