Re: [patch 4/4 2.6.23-rc2 + mm2-git-mmc] mmc_spi host driver

[David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>]

On Wednesday 29 August 2007, Pierre Ossman wrote:

> Could I get that patch instead? Pretty please? :)

=======	CUT HERE
Small bugfix for an issue noted by Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
whereby a buffer length was the passed with the wrong size.  This also
includes a minor cleanup, to eliminate the error-prone +1/-1 stuff.

Signed-off-by: David Brownell <dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
---
 drivers/mmc/host/mmc_spi.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

--- g26.orig/drivers/mmc/host/mmc_spi.c	2007-08-29 12:53:41.000000000 -0700
+++ g26/drivers/mmc/host/mmc_spi.c	2007-08-29 12:54:24.000000000 -0700
@@ -882,11 +882,12 @@ mmc_spi_data_do(struct mmc_spi_host *hos
 		list_add(&host->early_status.transfer_list,
 				&host->m.transfers);
 
+		memset(scratch->status, 0xff, statlen);
 		scratch->status[0] = SPI_TOKEN_STOP_TRAN;
-		memset(scratch->status + 1, 0xff, statlen - 1);
+
 		host->early_status.tx_buf = host->early_status.rx_buf;
 		host->early_status.tx_dma = host->early_status.rx_dma;
-		host->early_status.len = 1 + statlen;
+		host->early_status.len = statlen;
 
 		if (host->dma_dev)
 			dma_sync_single_for_device(host->dma_dev,

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/