From: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
To: Mike Frysinger <vapier.adi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: spi_set_drvdata() handling in spidev_probe()
Date: Thu, 10 Dec 2009 18:25:21 -0800 [thread overview]
Message-ID: <200912101825.21244.david-b@pacbell.net> (raw)
In-Reply-To: <8bd0f97a0910122332y321138ak8294e5f152064344-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Monday 12 October 2009, Mike Frysinger wrote:
> i was browsing the change history of spidev when i noticed the change:
> aaacf4bb51b243875b203e6ff73b5047636b4efa spi: avoid spidev crash when
> device is removed
>
> which seems to be due to this change:
> 3d81252ddb10f63ae4db713d9b32faabe641b850 device create: spi: convert
> device_create to device_create_drvdata
>
> getting an incomplete revert with this change:
> a9b12619f7b6f19c871437ec24a088787a04b1de device create: misc: convert
> device_create_drvdata to device_create
More accurately: not a revert, but a name change.
> my point being is that the original code was doing the
> spi_set_drvdata() while holding the device_list_lock mutex while the
> new one is not. shouldnt the code be changed back to the state
> previous to 3d81252d ?
Yes, that particular assignment should be mutex-protected.
The original patch shouldn't really have removed it; the
change to the device_create() signature was addressing a
slightly different race.
- Dave
> -mike
>
>
------------------------------------------------------------------------------
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
next prev parent reply other threads:[~2009-12-11 2:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-13 6:32 spi_set_drvdata() handling in spidev_probe() Mike Frysinger
[not found] ` <8bd0f97a0910122332y321138ak8294e5f152064344-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-12-11 2:25 ` David Brownell [this message]
[not found] ` <200912101825.21244.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2009-12-11 2:32 ` Mike Frysinger
[not found] ` <8bd0f97a0912101832g1398f6dbld984d55bbf37f4ee-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-12-11 3:03 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912101825.21244.david-b@pacbell.net \
--to=david-b-ybekhbn/0ldr7s880joybq@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=vapier.adi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).