From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH 1/9] spi/pxa2xx: don't use subys initcall for driver init Date: Thu, 25 Nov 2010 23:54:15 +0000 Message-ID: <20101125235415.GA9310@n2100.arm.linux.org.uk> References: <1290597207-29838-1-git-send-email-bigeasy@linutronix.de> <1290597207-29838-2-git-send-email-bigeasy@linutronix.de> <4CED1C95.8070300@linutronix.de> <20101124141623.GH24970@rakim.wolfsonmicro.main> <4CED3199.2040700@linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: David Brownell , eric.y.miao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Mark Brown , Haojian Zhuang , sodaville-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Dirk Brandewie , spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org, drwyrm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org To: Sebastian Andrzej Siewior Return-path: Content-Disposition: inline In-Reply-To: <4CED3199.2040700-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Wed, Nov 24, 2010 at 04:39:05PM +0100, Sebastian Andrzej Siewior wrote: > Mark Brown wrote: >> On Wed, Nov 24, 2010 at 03:09:25PM +0100, Sebastian Andrzej Siewior wrote: >> >>> I've been pointed out to this commit but I don't understand _why_. >>> The part I don't get is "so it can be used with cpufreq". Is it >>> refered to a driver or the subsystem as it? >> >> We need the regulators for the CPU rails to start before the cpufreq >> driver starts so cpufreq can talk to them, and since the regulators may >> be SPI attached this means we also need the SPI controller to start >> before cpufreq. cpufreq starts at vanilla init time. > > After digging through the code I think I've found it. pxa_cpu_init() > registers a cpufreq client. cpufreq calls init and pxa then > regulator_get() to get the regulator and I guess this is the problem. > So I would suggest to defer pxa_cpu_init() via late_initcall(). > > The other way around will force you to hack the init code for various > drivers to make it work. Why should the PXA code change when you haven't explained _why_ you want to change the SPI driver to conform to your idea? ------------------------------------------------------------------------------ Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! Tap into the largest installed PC base & get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev