From: Rob Herring <robh@kernel.org>
To: Georgi Djakov <georgi.djakov@linaro.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Alok Chauhan <alokc@codeaurora.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-spi@vger.kernel.org, linux-serial@vger.kernel.org,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
dianders@chromium.org, swboyd@chromium.org
Subject: Re: [PATCH 1/6] dt-bindings: soc: qcom: Add interconnect binding for GENI QUP
Date: Fri, 22 Feb 2019 18:26:55 -0600 [thread overview]
Message-ID: <20190223002655.GA6631@bogus> (raw)
In-Reply-To: <5ca1ce61-c458-5550-f89d-ab361f1ec456@linaro.org>
On Wed, Jan 23, 2019 at 08:41:20PM +0200, Georgi Djakov wrote:
> Hi,
>
> On 1/23/19 19:07, Bjorn Andersson wrote:
> > On Mon 21 Jan 22:33 PST 2019, Alok Chauhan wrote:
> >
> >> Add documentation for the interconnect and interconnect-names bindings
> >> for the GENI QUP as detailed by bindings/interconnect/interconnect.txt.
> >>
> >> Signed-off-by: Alok Chauhan <alokc@codeaurora.org>
> >> ---
> >> Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt | 10 ++++++++++
> >> 1 file changed, 10 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt
> >> index dab7ca9..44d7e02 100644
> >> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt
> >> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt
> >> @@ -17,6 +17,12 @@ Required properties if child node exists:
> >> - #address-cells: Must be <1> for Serial Engine Address
> >> - #size-cells: Must be <1> for Serial Engine Address Size
> >> - ranges: Must be present
> >> +- interconnects: phandle to a interconnect provider. Please refer
> >> + ../interconnect/interconnect.txt for details.
> >> + Must be 2 paths corresponding to 2 AXI ports.
> >> +- interconnect-names: Port names to differentiate between the
> >
> > s/Port names/Path names/
> >
> >> + 2 interconnect paths defined with interconnect
> >> + specifier.
> >
> > These two names are significant in that they must match what the driver
> > expects, hence you must actually specify them here.
> >
> > And as the scope of these strings are local to the QUP node you can omit
> > "qup" from them, so make them "memory" and "config" (or perhaps iface,
> > to match the clock naming?).
>
> Actually there was a discussion in the past where we decided include
> both the src and dst endpoint names in this property so that there is
> some symmetry with the "interconnects" property. It would be nice to be
> consistent across different drivers at least for now.
> If we want to denote the master and slave ports here, my two cents would
> be for "qup-mem" and "cpu-qup" or something similar?
Well, there's a proposal from Maxime to add 'dma-memory' or something.
You all need to sort this out.
I assume config or cpu-qup is for register access? Why is this needed?
That should get described thru the DT tree. The interconnect stuff was
supposed to be for the non-cpu centric view (i.e. DMA masters). Maybe
it's fine, but that's not my initial reaction.
Rob
next prev parent reply other threads:[~2019-02-23 0:26 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 6:33 [PATCH 0/6] Add interconnect support for GENI QUPs Alok Chauhan
2019-01-22 6:33 ` [PATCH 1/6] dt-bindings: soc: qcom: Add interconnect binding for GENI QUP Alok Chauhan
2019-01-23 6:48 ` alokc
2019-01-23 17:07 ` Bjorn Andersson
2019-01-23 18:41 ` Georgi Djakov
2019-02-23 0:26 ` Rob Herring [this message]
2019-02-25 17:39 ` Georgi Djakov
2019-01-23 18:35 ` Georgi Djakov
2019-01-30 22:29 ` alokc
2019-01-24 1:10 ` Evan Green
2019-01-30 22:27 ` alokc
2019-01-22 6:33 ` [PATCH 2/6] soc: qcom: Add wrapper to support for Interconnect path Alok Chauhan
2019-01-23 7:02 ` alokc
2019-01-23 18:14 ` Bjorn Andersson
2019-01-22 6:33 ` [PATCH 3/6] i2c: i2c-qcom-geni: Add interconnect support Alok Chauhan
2019-01-22 9:07 ` Wolfram Sang
2019-01-22 9:13 ` Peter Rosin
2019-01-23 6:51 ` alokc
2019-01-24 1:19 ` Evan Green
2019-01-22 6:33 ` [PATCH 4/6] spi: spi-geni-qcom: " Alok Chauhan
2019-01-22 20:29 ` Mark Brown
2019-01-23 7:15 ` alokc
2019-01-23 10:58 ` Mark Brown
2019-01-23 16:04 ` Mark Brown
2019-01-24 1:20 ` Evan Green
2019-01-22 6:33 ` [PATCH 5/6] tty: serial: qcom_geni_serial: " Alok Chauhan
2019-01-23 6:53 ` alokc
2019-01-22 6:33 ` [PATCH 6/6] arm64: dts: sdm845: Add interconnect for GENI QUP Alok Chauhan
2019-01-23 6:54 ` alokc
2019-01-23 6:45 ` [PATCH 0/6] Add interconnect support for GENI QUPs alokc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190223002655.GA6631@bogus \
--to=robh@kernel.org \
--cc=alokc@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=georgi.djakov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).