From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Geert Uytterhoeven
<geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Yoshihiro Shimoda
<yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Geert Uytterhoeven
<geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
Subject: Re: [PATCH v3 2/2] spi: dt-bindings: spi-controller: Fix spi-[rt]x-bus-width for slave mode
Date: Thu, 12 Mar 2020 14:17:36 -0500 [thread overview]
Message-ID: <20200312191736.GA15869@bogus> (raw)
In-Reply-To: <20200306085038.8111-3-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
On Fri, 6 Mar 2020 09:50:38 +0100, Geert Uytterhoeven wrote:
> The descriptions for the spi-rx-bus-width and spi-tx-bus-width
> properties refer to "MISO" and "MOSI", which are not explained in the
> document. While these abbreviations are fairly common when talking
> about SPI, and thus may not need an explanation, they are not entirely
> correct in this context, as the SPI controller may be used in slave mode
> instead of master mode.
>
> Fix this by replacing them by "read transfers" resp. "write transfers",
> like is done for the spi-rx-delay-us and spi-tx-delay-us properties.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
> ---
> v3:
> - No changes,
>
> v2:
> - New.
>
> This issue was present in the .txt version of the bindings, too, so
> technically it needs
> Fixes: a8830cb19cfea04e ("spi: Document DT bindings for SPI controllers in slave mode")
> but of course it won't apply to that version.
> ---
> Documentation/devicetree/bindings/spi/spi-controller.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
next prev parent reply other threads:[~2020-03-12 19:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 8:50 [PATCH v3 0/2] spi: dt-bindings: spi-controller: Slave mode fixes Geert Uytterhoeven
2020-03-06 8:50 ` [PATCH v3 1/2] spi: dt-bindings: spi-controller: Fix #address-cells for slave mode Geert Uytterhoeven
[not found] ` <20200306085038.8111-2-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
2020-03-12 19:16 ` Rob Herring
2020-03-13 17:06 ` Applied "spi: dt-bindings: spi-controller: Fix #address-cells for slave mode" to the spi tree Mark Brown
[not found] ` <20200306085038.8111-1-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
2020-03-06 8:50 ` [PATCH v3 2/2] spi: dt-bindings: spi-controller: Fix spi-[rt]x-bus-width for slave mode Geert Uytterhoeven
[not found] ` <20200306085038.8111-3-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
2020-03-12 19:17 ` Rob Herring [this message]
2020-03-13 17:20 ` Patchwork summary for: spi-devel-general patchwork-bot+linux-spi-DgEjT+Ai2ygdnm+yROfE0A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200312191736.GA15869@bogus \
--to=robh-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org \
--cc=linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).