From: Mark Brown <broonie@kernel.org>
To: Clark Wang <xiaoning.wang@nxp.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] spi: lpspi: fix kernel warning dump when probe fail after calling spi_register
Date: Tue, 14 Jul 2020 12:37:12 +0100 [thread overview]
Message-ID: <20200714113712.GE4900@sirena.org.uk> (raw)
In-Reply-To: <20200714075251.12777-4-xiaoning.wang@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 1033 bytes --]
On Tue, Jul 14, 2020 at 03:52:49PM +0800, Clark Wang wrote:
> Calling devm_spi_register_controller() too early will cause problem.
> When probe failed occurs after calling devm_spi_register_controller(),
> the call of spi_controller_put() will trigger the following warning dump.
>
> [ 2.092138] ------------[ cut here ]------------
> [ 2.096876] kernfs: can not remove 'uevent', no directory
> [ 2.102440] WARNING: CPU: 0 PID: 181 at fs/kernfs/dir.c:1503 kernfs_remove_by_name_ns+0xa0/0xb0
> [ 2.111142] Modules linked in:
> [ 2.114207] CPU: 0 PID: 181 Comm: kworker/0:7 Not tainted 5.4.24-05024-g775c6e8a738c-dirty #1314
Please think hard before including complete backtraces in upstream
reports, they are very large and contain almost no useful information
relative to their size so often obscure the relevant content in your
message. If part of the backtrace is usefully illustrative (it often is
for search engines if nothing else) then it's usually better to pull out
the relevant sections.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-07-14 11:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 7:52 [PATCH 0/5] Some bug fix for lpspi Clark Wang
2020-07-14 7:52 ` [PATCH 1/5] spi: lpspi: fix the imbalance of runtime pm function call Clark Wang
2020-07-14 7:52 ` [PATCH 2/5] spi: lpspi: add NULL check when probe device Clark Wang
2020-07-21 23:44 ` Mark Brown
2020-07-14 7:52 ` [PATCH 3/5] spi: lpspi: fix kernel warning dump when probe fail after calling spi_register Clark Wang
2020-07-14 11:37 ` Mark Brown [this message]
2020-07-21 22:47 ` Mark Brown
2020-07-14 7:52 ` [PATCH 4/5] spi: lpspi: handle EPROBE_DEFER when get cs-gpios number Clark Wang
2020-07-14 7:52 ` [PATCH 5/5] spi: lpspi: fix using CS discontinuously on i.MX8DXLEVK Clark Wang
2020-07-22 13:45 ` [PATCH 0/5] Some bug fix for lpspi Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714113712.GE4900@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).