On Wed, Sep 30, 2020 at 06:03:12PM +0300, Serge Semin wrote: > On Wed, Sep 30, 2020 at 01:17:37AM +0300, Serge Semin wrote: > > > > - /* > > > > - * SPI mode (SCPOL|SCPH) > > > > - * CTRLR0[ 8] Serial Clock Phase > > > > - * CTRLR0[ 9] Serial Clock Polarity > > > > - */ > > > > - cr0 |= ((spi->mode & SPI_CPOL) ? 1 : 0) << DWC_SSI_CTRLR0_SCPOL_OFFSET; > anyway. If you are agree with me having that done here, then please, accept the > patch the way it is. If you disagree, or have any other though, please give me > your answer, why. Those comments did seem to help mitigate the wall of acronym soup issue that the code has, it seems a shame to drop them.