From: Pratyush Yadav <p.yadav@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
zhengxunli <zhengxunli@mxic.com.tw>, <vigneshr@ti.com>,
<juliensu@mxic.com.tw>, <ycllin@mxic.com.tw>,
<linux-spi@vger.kernel.org>, <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH v2 1/2] mtd: spi-nor: macronix: add support for Macronix octaflash
Date: Tue, 23 Feb 2021 20:55:06 +0530 [thread overview]
Message-ID: <20210223152504.jtq4uxfepz7bdxhl@ti.com> (raw)
In-Reply-To: <20210223133649.GD5116@sirena.org.uk>
On 23/02/21 01:36PM, Mark Brown wrote:
> On Tue, Feb 23, 2021 at 02:13:44PM +0100, Miquel Raynal wrote:
> > Pratyush Yadav <p.yadav@ti.com> wrote on Fri, 5 Feb 2021 19:04:04 +0530:
>
> > > [0] Since SPI NOR has no way of knowing what speed the controller is
> > > running at, assume the fastest speed the flash can run at.
>
> > Ok, I am not entirely clear about what is available/not available from
> > the SPI core.
>
> > If this is true then I guess we can't do better with the current code
> > base and this can be improved in the future if needed. So I'm fine with
> > the current implementation.
>
> For normal SPI operations you can set the speed (really, top speed) on a
> per transfer basis.
To select the optimal number of dummy cycles we need to know what speed
the controller is running at, not the other way around. The flash would
always set the top speed to its maximum (say 200 MHz). But if the
controller is only capable of running at 50 MHz, you will end up wasting
dummy cycles. I don't see any API to communicate speed from controller
to flash.
--
Regards,
Pratyush Yadav
Texas Instruments Inc.
next prev parent reply other threads:[~2021-02-23 15:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 9:36 [PATCH v2 0/2] Add octal DTR support for Macronix flash zhengxunli
2021-02-05 9:36 ` [PATCH v2 1/2] mtd: spi-nor: macronix: add support for Macronix octaflash zhengxunli
2021-02-05 9:47 ` Miquel Raynal
2021-02-05 13:34 ` Pratyush Yadav
2021-02-05 13:50 ` Miquel Raynal
2021-02-23 13:13 ` Miquel Raynal
2021-02-23 13:36 ` Mark Brown
2021-02-23 15:25 ` Pratyush Yadav [this message]
2021-02-23 18:07 ` Geert Uytterhoeven
2021-02-23 18:14 ` Mark Brown
[not found] ` <OF5890F10B.27BC3B4B-ON482586A7.001FE05B-482586A7.0024305D@mxic.com.tw>
2021-04-05 4:41 ` Tudor.Ambarus
2021-02-05 9:36 ` [PATCH v2 2/2] spi: mxic: patch for octal DTR mode support zhengxunli
2021-02-19 5:58 ` zhengxunli
2021-02-23 13:28 ` Mark Brown
2021-08-09 13:06 ` (subset) [PATCH v2 0/2] Add octal DTR support for Macronix flash Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210223152504.jtq4uxfepz7bdxhl@ti.com \
--to=p.yadav@ti.com \
--cc=broonie@kernel.org \
--cc=juliensu@mxic.com.tw \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=vigneshr@ti.com \
--cc=ycllin@mxic.com.tw \
--cc=zhengxunli@mxic.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).