From: Rob Herring <robh@kernel.org>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Kuldeep Singh <kuldeep.singh@nxp.com>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@kernel.org>
Subject: Re: [EXT] Re: [PATCH] dt-bindings: spi: Convert Freescale DSPI to json schema
Date: Wed, 24 Mar 2021 12:14:03 -0600 [thread overview]
Message-ID: <20210324181403.GC3320002@robh.at.kernel.org> (raw)
In-Reply-To: <20210316101506.rkqcxkw6slv4vuhr@skbuf>
On Tue, Mar 16, 2021 at 12:15:06PM +0200, Vladimir Oltean wrote:
> On Tue, Mar 16, 2021 at 06:08:17AM +0000, Kuldeep Singh wrote:
> > Compatible entries in conjugation require enum and const pair.
> > For example, ls1012a.dtsi uses compatible = "fsl,ls1012a-dspi","fsl,ls1021a-v1.0-dspi";
> > Same goes for LS1028 as well.
> >
> > Therefore, can't mention the compatible entry as single entity otherwise
> > it may fail "make dt_binding_check" and "make dtbs_check".
> >
> > >
> > > > +examples:
> > > > + - |
> > > > + #include <dt-bindings/clock/fsl,qoriq-clockgen.h>
> > > > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > > > +
> > > > + soc {
> > > > + #address-cells = <2>;
> > > > + #size-cells = <2>;
> > > > +
> > > > + spi@2100000 {
> > > > + compatible = "fsl,ls1028a-dspi", "fsl,ls1021a-v1.0-dspi";
> > >
> > > This doesn't need the "fsl,ls1021a-v1.0-dspi" compatible, can you please remove
> > > it?
> >
> > I have taken this example from LS1028a.dtsi and it uses these compatibles in conjugation.
> > If "fsl,ls1021a-v1.0-dspi" is not required, then it should also be removed from device-tree
> > As well as from bindings both.
>
> Yes, the second compatible is never required by the driver and should be
> removed from existing device trees if that makes "make dtbs_check" fail.
Can you say that is true for every possible driver implementation?
u-boot, *BSD, etc.?
Rob
next prev parent reply other threads:[~2021-03-24 18:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 12:15 [PATCH] dt-bindings: spi: Convert Freescale DSPI to json schema Kuldeep Singh
2021-03-15 18:30 ` Pratyush Yadav
2021-03-16 5:56 ` [EXT] " Kuldeep Singh
2021-03-16 17:45 ` Michael Walle
2021-03-16 18:06 ` Pratyush Yadav
2021-03-16 18:22 ` Michael Walle
2021-03-24 17:51 ` Rob Herring
2021-03-22 13:20 ` Pratyush Yadav
2021-03-24 18:10 ` Rob Herring
2021-03-15 20:54 ` Vladimir Oltean
2021-03-16 6:08 ` [EXT] " Kuldeep Singh
2021-03-16 10:15 ` Vladimir Oltean
2021-03-24 18:14 ` Rob Herring [this message]
2021-03-24 18:53 ` Vladimir Oltean
2021-03-24 19:20 ` Rob Herring
2021-03-25 1:06 ` Vladimir Oltean
2021-03-24 18:18 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210324181403.GC3320002@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kuldeep.singh@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=olteanv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).