From: Mark Brown <broonie@kernel.org>
To: Ben Wolsieffer <ben.wolsieffer@hefring.com>
Cc: "Leonard Göhrs" <l.goehrs@pengutronix.de>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-spi@vger.kernel.org,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alain Volmat" <alain.volmat@foss.st.com>
Subject: Re: [PATCH v2] spi: stm32: enable controller before asserting CS
Date: Tue, 14 May 2024 09:51:14 +0100 [thread overview]
Message-ID: <32d2be34-07e5-4f99-bd31-12aeb9bdce09@sirena.org.uk> (raw)
In-Reply-To: <ZkJBqSbJakye6BBc@dell-precision-5540>
[-- Attachment #1: Type: text/plain, Size: 1281 bytes --]
On Mon, May 13, 2024 at 12:36:57PM -0400, Ben Wolsieffer wrote:
> On Mon, May 13, 2024 at 10:29:49AM +0200, Leonard Göhrs wrote:
> > Reverting this commit fixes the issue for me. It may be some time before
> > I get around to investigating the issue in detail, so I thought I should
> > ask if anyone else has already noticed this as well.
> Sorry about that; it looks like the STM32H7/MP platforms require the
> controller to be enabled later. I agree that it should be reverted and
> I'll try to think of another approach.
Can one of you please send a patch with the revert and a changelog
explaining the issue?
> The STM32H7/MP devices are significantly different from the F4/7
> devices, which makes it difficult to change shared code without causing
> problems like this. I wonder if it might be better to split the F4/7
> support into a separate driver. This would duplicate a bit of code,
> namely the initialization in probe, the baud rate divider calculation
> and the SPI mode config, but would make testing easier and get rid of
> the indirection that handles the different register offsets and field
> masks on each platform. The code for actually transcieving data and
> handling IRQs is already platform specific.
That might make sense.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2024-05-14 8:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 13:52 [PATCH v2] spi: stm32: enable controller before asserting CS Ben Wolsieffer
2024-05-05 15:03 ` Mark Brown
2024-05-13 8:29 ` Leonard Göhrs
2024-05-13 16:36 ` Ben Wolsieffer
2024-05-14 8:51 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32d2be34-07e5-4f99-bd31-12aeb9bdce09@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alain.volmat@foss.st.com \
--cc=alexandre.torgue@foss.st.com \
--cc=ben.wolsieffer@hefring.com \
--cc=kernel@pengutronix.de \
--cc=l.goehrs@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).