From: Cory Maccarrone <darkstar6262@gmail.com>
To: jassi brar <jassisinghbrar@gmail.com>
Cc: spi-devel-general@lists.sourceforge.net, linux-omap@vger.kernel.org
Subject: Re: [spi-devel-general] [PATCH 1/3] [SPI] [OMAP] Add OMAP spi100k driver
Date: Sun, 6 Dec 2009 22:36:01 -0800 [thread overview]
Message-ID: <6cb013310912062236p1914a979i76f846e00ee5c32@mail.gmail.com> (raw)
In-Reply-To: <1b68c6790912062133kdc901dcnbb043ce14fc1049@mail.gmail.com>
On Sun, Dec 6, 2009 at 9:33 PM, jassi brar <jassisinghbrar@gmail.com> wrote:
> setting master->cleanup = NULL shud do
>
> how about dropping it altogether?
>
> no need for cleanup callback if u have nothing to do in _close.
>
> no need of {}
>
> the status shud default to -EINPROGRESS, not success.
>
> In remove you might want to wait for mssg queue to be flushed?
>
All good points. I'll make my corrections and resubmit.
Thanks
- Cory
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-12-07 6:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-07 4:48 [PATCH 0/3] Add spi100k driver and arch support Cory Maccarrone
2009-12-07 4:48 ` [PATCH 1/3] [SPI] [OMAP] Add OMAP spi100k driver Cory Maccarrone
[not found] ` <1260161299-17656-2-git-send-email-darkstar6262-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-12-07 5:33 ` jassi brar
2009-12-07 6:36 ` Cory Maccarrone [this message]
2009-12-07 18:08 ` Tony Lindgren
2009-12-07 4:48 ` [PATCH 2/3] [OMAP] Add spi100k configuration to OMAP1 Cory Maccarrone
2009-12-07 18:14 ` Tony Lindgren
2009-12-07 4:48 ` [PATCH 3/3] [OMAP] Add OMAP 7xx pin muxes for SPI Cory Maccarrone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cb013310912062236p1914a979i76f846e00ee5c32@mail.gmail.com \
--to=darkstar6262@gmail.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).