linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Walle <michael-QKn5cuLxLXY@public.gmane.org>
To: Vladimir Oltean <olteanv-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	eha-/iRVSOupHO4@public.gmane.org,
	angelo-BIYBQhTR83Y@public.gmane.org,
	andrew.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	gustavo-L1vi/lXTdts+Va1GwOuvDg@public.gmane.org,
	weic-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
	mhosny-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
	peng.ma-3arQi8VN3Tc@public.gmane.org
Subject: Re: [PATCH 5/6] arm64: dts: ls1028a: Specify the DMA channels for the DSPI controllers
Date: Mon, 09 Mar 2020 20:06:30 +0100	[thread overview]
Message-ID: <83af52172a3cabd662de1ed9574e4247@walle.cc> (raw)
In-Reply-To: <20200309145624.10026-6-olteanv-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Am 2020-03-09 15:56, schrieb Vladimir Oltean:
> From: Vladimir Oltean <vladimir.oltean-3arQi8VN3Tc@public.gmane.org>
> 
> LS1028A has a functional connection to the eDMA module. Even if the
> spi-fsl-dspi.c driver is not using DMA for LS1028A now, define the 
> slots
> in the DMAMUX for connecting the eDMA channels to the 3 DSPI
> controllers.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean-3arQi8VN3Tc@public.gmane.org>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 515e0a1b934f..18155273a46e 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -298,6 +298,8 @@
>  			interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
>  			clock-names = "dspi";
>  			clocks = <&clockgen 4 1>;
> +			dmas = <&edma0 0 62>, <&edma0 0 60>;
> +			dma-names = "tx", "rx";

minor nit. Other nodes specified the dma channels as

dma-names = "tx", "rx";
dmas = <&edma0 0 62>,
        <&edma0 0 60>;

-michael

>  			spi-num-chipselects = <4>;
>  			little-endian;
>  			status = "disabled";
> @@ -311,6 +313,8 @@
>  			interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
>  			clock-names = "dspi";
>  			clocks = <&clockgen 4 1>;
> +			dmas = <&edma0 0 58>, <&edma0 0 56>;
> +			dma-names = "tx", "rx";
>  			spi-num-chipselects = <4>;
>  			little-endian;
>  			status = "disabled";
> @@ -324,6 +328,8 @@
>  			interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
>  			clock-names = "dspi";
>  			clocks = <&clockgen 4 1>;
> +			dmas = <&edma0 0 54>, <&edma0 0 2>;
> +			dma-names = "tx", "rx";
>  			spi-num-chipselects = <3>;
>  			little-endian;
>  			status = "disabled";

  parent reply	other threads:[~2020-03-09 19:06 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-09 14:56 [PATCH 0/6] NXP DSPI bugfixes and support for LS1028A Vladimir Oltean
2020-03-09 14:56 ` [PATCH 1/6] spi: spi-fsl-dspi: Don't access reserved fields in SPI_MCR Vladimir Oltean
     [not found]   ` <20200309145624.10026-2-olteanv-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-03-09 18:05     ` Michael Walle
     [not found]       ` <c35b3c34123b43b26204a2cf360e7ec1-QKn5cuLxLXY@public.gmane.org>
2020-03-09 18:09         ` Vladimir Oltean
2020-03-09 14:56 ` [PATCH 2/6] spi: spi-fsl-dspi: Fix little endian access to PUSHR CMD and TXDATA Vladimir Oltean
     [not found]   ` <20200309145624.10026-3-olteanv-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-03-09 17:59     ` Michael Walle
     [not found]       ` <d8e39e402328b962cdbc25316a27eac8-QKn5cuLxLXY@public.gmane.org>
2020-03-09 18:07         ` Vladimir Oltean
     [not found]           ` <CA+h21hp4vC1c00rCgZo_hwQz3cE4dLBHjcgTHvf-+fS9a9VfxQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-03-09 18:19             ` Michael Walle
     [not found]               ` <a709dc91aac9124ed37ac1e7fcb7e105-QKn5cuLxLXY@public.gmane.org>
2020-03-09 18:31                 ` Vladimir Oltean
2020-03-09 14:56 ` [PATCH 4/6] spi: spi-fsl-dspi: Add support for LS1028A Vladimir Oltean
     [not found]   ` <20200309145624.10026-5-olteanv-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-03-09 18:38     ` Michael Walle
     [not found]       ` <02a2816d2f39bf621dfee543ed612ae0-QKn5cuLxLXY@public.gmane.org>
2020-03-09 18:51         ` Vladimir Oltean
     [not found] ` <20200309145624.10026-1-olteanv-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-03-09 14:56   ` [PATCH 3/6] spi: spi-fsl-dspi: Fix oper_word_size of zero for DMA mode Vladimir Oltean
2020-03-09 14:56   ` [PATCH 5/6] arm64: dts: ls1028a: Specify the DMA channels for the DSPI controllers Vladimir Oltean
     [not found]     ` <20200309145624.10026-6-olteanv-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-03-09 19:06       ` Michael Walle [this message]
     [not found]         ` <83af52172a3cabd662de1ed9574e4247-QKn5cuLxLXY@public.gmane.org>
2020-03-09 19:59           ` Vladimir Oltean
2020-03-09 20:17             ` Michael Walle
2020-03-09 14:56   ` [PATCH 6/6] arm64: dts: ls1028a-rdb: Add a spidev node for the mikroBUS Vladimir Oltean
     [not found]     ` <20200309145624.10026-7-olteanv-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-03-09 18:35       ` Michael Walle
     [not found]         ` <f213388d924b63d0fe265a2d731647be-QKn5cuLxLXY@public.gmane.org>
2020-03-09 18:50           ` Vladimir Oltean
     [not found]             ` <CA+h21hqOhM9+k9cKXoA8coYpxNFWpgD+FjETeB6uWLbsfrx0uw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-03-09 18:58               ` Michael Walle
2020-03-09 18:03   ` [PATCH 0/6] NXP DSPI bugfixes and support for LS1028A Michael Walle
     [not found]     ` <f530a0740f34b2cf26a8055d4eae2527-QKn5cuLxLXY@public.gmane.org>
2020-03-09 18:14       ` Vladimir Oltean
2020-03-09 18:31         ` Michael Walle
2020-03-09 18:48           ` Vladimir Oltean
     [not found]             ` <CA+h21hopP2XTx55iu_pG=xBx-TSPRBbdmoU7T2F0Gc9Qt=CsSQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-03-09 18:59               ` Michael Walle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83af52172a3cabd662de1ed9574e4247@walle.cc \
    --to=michael-qkn5culxlxy@public.gmane.org \
    --cc=andrew.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=angelo-BIYBQhTR83Y@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=eha-/iRVSOupHO4@public.gmane.org \
    --cc=gustavo-L1vi/lXTdts+Va1GwOuvDg@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=mhosny-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=olteanv-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=peng.ma-3arQi8VN3Tc@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=weic-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).