From: Lars Povlsen <lars.povlsen@microchip.com>
To: Rob Herring <robh@kernel.org>
Cc: Lars Povlsen <lars.povlsen@microchip.com>,
Mark Brown <broonie@kernel.org>, Peter Rosin <peda@axentia.se>,
"Microchip Linux Driver Support" <UNGLinuxDriver@microchip.com>,
<linux-spi@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Serge Semin <fancer.lancer@gmail.com>,
Serge Semin <Sergey.Semin@baikalelectronics.ru>
Subject: Re: [PATCH v4 4/6] dt-bindings: snps,dw-apb-ssi: Add sparx5 support, plus rx-sample-delay-ns property
Date: Tue, 28 Jul 2020 10:11:02 +0200 [thread overview]
Message-ID: <87sgdcf4a1.fsf@soft-dev15.microsemi.net> (raw)
In-Reply-To: <20200727203847.GA782308@bogus>
Rob Herring writes:
> On Fri, Jul 24, 2020 at 01:14:02PM +0200, Lars Povlsen wrote:
>> This has the following changes for the snps,dw-apb-ss DT bindings:
>>
>> - Add "microchip,sparx5-spi" as the compatible for the Sparx5 SoC
>> controller
>>
>> - Add the property "rx-sample-delay-ns"
>>
>> Signed-off-by: Lars Povlsen <lars.povlsen@microchip.com>
>> ---
>> .../bindings/spi/snps,dw-apb-ssi.yaml | 21 +++++++++++++++++++
>> 1 file changed, 21 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
>> index c62cbe79f00dd..c0adaad1aa695 100644
>> --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
>> +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
>> @@ -36,6 +36,8 @@ properties:
>> - mscc,ocelot-spi
>> - mscc,jaguar2-spi
>> - const: snps,dw-apb-ssi
>> + - description: Microchip Sparx5 SoC SPI Controller
>> + const: microchip,sparx5-spi
>> - description: Amazon Alpine SPI Controller
>> const: amazon,alpine-dw-apb-ssi
>> - description: Renesas RZ/N1 SPI Controller
>> @@ -93,6 +95,12 @@ properties:
>> - const: tx
>> - const: rx
>>
>> + rx-sample-delay-ns:
>> + description: Default value of the rx-sample-delay-ns property.
>> + This value will be used if the property is not explicitly defined
>> + for a SPI slave device. Default value is 0. See below.
>> + $ref: /schemas/types.yaml#/definitions/uint32
>
> Don't need a type for properties with unit suffixes.
>
> Also, add:
>
> 'default: 0'
>
Hi Rob!
Thank you for your input, all duly noted.
---Lars
>> +
>> patternProperties:
>> "^.*@[0-9a-f]+$":
>> type: object
>> @@ -107,6 +115,13 @@ patternProperties:
>> spi-tx-bus-width:
>> const: 1
>>
>> + rx-sample-delay-ns:
>> + description: SPI Rx sample delay offset, unit is nanoseconds.
>> + The delay from the default sample time before the actual
>> + sample of the rxd input signal occurs. The "rx_sample_delay"
>> + is an optional feature of the designware controller, and the
>> + upper limit is also subject to controller configuration.
>> +
>> unevaluatedProperties: false
>>
>> required:
>> @@ -129,5 +144,11 @@ examples:
>> num-cs = <2>;
>> cs-gpios = <&gpio0 13 0>,
>> <&gpio0 14 0>;
>> + rx-sample-delay-ns = <3>;
>> + spi-flash@1 {
>> + compatible = "spi-nand";
>> + reg = <1>;
>> + rx-sample-delay-ns = <7>;
>> + };
>> };
>> ...
>> --
>> 2.27.0
>>
--
Lars Povlsen,
Microchip
next prev parent reply other threads:[~2020-07-28 8:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 11:13 [PATCH v4 0/6] spi: Adding support for Microchip Sparx5 SoC Lars Povlsen
2020-07-24 11:13 ` [PATCH v4 1/6] spi: dw: Add support for RX sample delay register Lars Povlsen
2020-07-24 11:14 ` [PATCH v4 2/6] spi: dw: Add Microchip Sparx5 support Lars Povlsen
2020-07-24 11:14 ` [PATCH v4 3/6] arm64: dts: sparx5: Add SPI controller and associated mmio-mux Lars Povlsen
2020-07-24 11:14 ` [PATCH v4 4/6] dt-bindings: snps,dw-apb-ssi: Add sparx5 support, plus rx-sample-delay-ns property Lars Povlsen
2020-07-27 20:38 ` Rob Herring
2020-07-28 8:11 ` Lars Povlsen [this message]
2020-07-24 11:14 ` [PATCH v4 5/6] arm64: dts: sparx5: Add spi-nor support Lars Povlsen
2020-07-24 11:14 ` [PATCH v4 6/6] arm64: dts: sparx5: Add spi-nand devices Lars Povlsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgdcf4a1.fsf@soft-dev15.microsemi.net \
--to=lars.povlsen@microchip.com \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=UNGLinuxDriver@microchip.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=peda@axentia.se \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).