From mboxrd@z Thu Jan 1 00:00:00 1970 From: Haojian Zhuang Subject: Re: [PATCH 1/9] spi/pxa2xx: don't use subys initcall for driver init Date: Wed, 24 Nov 2010 21:54:33 +0800 Message-ID: References: <1290597207-29838-1-git-send-email-bigeasy@linutronix.de> <1290597207-29838-2-git-send-email-bigeasy@linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: David Brownell , eric.y.miao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, sodaville-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org, Dirk Brandewie , spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Sebastian Andrzej Siewior , drwyrm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Mark Brown Return-path: In-Reply-To: <1290597207-29838-2-git-send-email-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Wed, Nov 24, 2010 at 7:13 PM, Sebastian Andrzej Siewior wrote: > It is a simple driver and there is no need to call its init function > at the level of a subsystem. > > Signed-off-by: Sebastian Andrzej Siewior > Signed-off-by: Dirk Brandewie > --- > =A0drivers/spi/pxa2xx_spi.c | =A0 =A02 +- > =A01 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/spi/pxa2xx_spi.c b/drivers/spi/pxa2xx_spi.c > index e76b1af..6f2f061 100644 > --- a/drivers/spi/pxa2xx_spi.c > +++ b/drivers/spi/pxa2xx_spi.c > @@ -1731,7 +1731,7 @@ static int __init pxa2xx_spi_init(void) > =A0{ > =A0 =A0 =A0 =A0return platform_driver_probe(&driver, pxa2xx_spi_probe); > =A0} > -subsys_initcall(pxa2xx_spi_init); > +module_init(pxa2xx_spi_init); > > =A0static void __exit pxa2xx_spi_exit(void) > =A0{ > -- Hi Sebastian, Actually it's added for cpufreq usage. We can check the commit in below. commit 5b61a749e8fd0a45a5e37c267d20a43ef0590d68 Author: Antonio Ospite Date: Tue Sep 22 16:46:10 2009 -0700 pxa2xx_spi: register earlier Register pxa2xx_spi earlier so it can be used with cpufreq Signed-off-by: Daniel Ribeiro Acked-by: Mark Brown So I think that this modifcation may cause others brokne. Thanks Haojian ---------------------------------------------------------------------------= --- Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! Tap into the largest installed PC base & get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev