From: Michael Walle <michael@walle.cc>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
Vladimir Oltean <olteanv@gmail.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>
Subject: Re: [PATCH v3] spi: fsl-dspi: fix NULL pointer dereference
Date: Tue, 01 Dec 2020 15:04:27 +0100 [thread overview]
Message-ID: <c1dd024150ed624a6b42562573851f84@walle.cc> (raw)
In-Reply-To: <160683107674.35139.13937083243515034859.b4-ty@kernel.org>
Hi Mark,
Am 2020-12-01 14:57, schrieb Mark Brown:
> On Mon, 28 Sep 2020 10:55:00 +0200, Michael Walle wrote:
>> Since commit 530b5affc675 ("spi: fsl-dspi: fix use-after-free in
>> remove
>> path") this driver causes a kernel oops:
>>
>> [ 1.891065] Unable to handle kernel NULL pointer dereference at
>> virtual address 0000000000000080
>> [..]
>> [ 2.056973] Call trace:
>> [ 2.059425] dspi_setup+0xc8/0x2e0
>> [ 2.062837] spi_setup+0xcc/0x248
>> [ 2.066160] spi_add_device+0xb4/0x198
>> [ 2.069918] of_register_spi_device+0x250/0x370
>> [ 2.074462] spi_register_controller+0x4f4/0x770
>> [ 2.079094] dspi_probe+0x5bc/0x7b0
>> [ 2.082594] platform_drv_probe+0x5c/0xb0
>> [ 2.086615] really_probe+0xec/0x3c0
>> [ 2.090200] driver_probe_device+0x60/0xc0
>> [ 2.094308] device_driver_attach+0x7c/0x88
>> [ 2.098503] __driver_attach+0x60/0xe8
>> [ 2.102263] bus_for_each_dev+0x7c/0xd0
>> [ 2.106109] driver_attach+0x2c/0x38
>> [ 2.109692] bus_add_driver+0x194/0x1f8
>> [ 2.113538] driver_register+0x6c/0x128
>> [ 2.117385] __platform_driver_register+0x50/0x60
>> [ 2.122105] fsl_dspi_driver_init+0x24/0x30
>> [ 2.126302] do_one_initcall+0x54/0x2d0
>> [ 2.130149] kernel_init_freeable+0x1ec/0x258
>> [ 2.134520] kernel_init+0x1c/0x120
>> [ 2.138018] ret_from_fork+0x10/0x34
>> [ 2.141606] Code: 97e0b11d aa0003f3 b4000680 f94006e0 (f9404000)
>> [ 2.147723] ---[ end trace 26cf63e6cbba33a8 ]---
>>
>> [...]
>
> Applied to
>
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
> for-next
Is that correct? Some time ago you've already applied that to your spi
tree:
https://lore.kernel.org/linux-spi/160132174502.55568.11234605078950751454.b4-ty@kernel.org/
-michael
next prev parent reply other threads:[~2020-12-01 14:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 8:55 [PATCH v3] spi: fsl-dspi: fix NULL pointer dereference Michael Walle
2020-09-28 19:35 ` Mark Brown
2020-10-09 11:01 ` Naresh Kamboju
2020-10-09 19:20 ` Michael Walle
2020-12-01 13:57 ` Mark Brown
2020-12-01 14:04 ` Michael Walle [this message]
2020-12-01 14:35 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1dd024150ed624a6b42562573851f84@walle.cc \
--to=michael@walle.cc \
--cc=broonie@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).