From: Sunny Luo <sunny.luo@amlogic.com>
To: Neil Armstrong <narmstrong@baylibre.com>,
Mark Brown <broonie@kernel.org>
Cc: Yixun Lan <yixun.lan@amlogic.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Carlo Caione <carlo@caione.org>,
Jianxin Pan <jianxin.pan@amlogic.com>,
Xingyu Chen <xingyu.chen@amlogic.com>,
<linux-spi@vger.kernel.org>, <linux-amlogic@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] spi: meson-axg: enhance output enable feature
Date: Thu, 13 Dec 2018 21:12:23 +0800 [thread overview]
Message-ID: <c85195d4-29e5-0e66-da09-cb86248660a3@amlogic.com> (raw)
In-Reply-To: <6ba11b0a-3629-5378-61c7-3cc364237f5c@baylibre.com>
Hi Neil,
On 2018/12/13 16:53, Neil Armstrong wrote:
> Hi Sunny,
>
> On 13/12/2018 09:39, Sunny Luo wrote:
>> The SPICC controller in Meson-AXG is capable of driving the CLK/MOSI/SS
>> signal lines through the idle state (between two transmission operation),
>> which avoid the signals floating in unexpected state.
>
> This is welcome, because it's really missing on GX...
> I tried implementing it with pinctrl at [1], but it's complex.
>
> Can you provide more info on how we should implement in on GX to be on par ?
>
> [1] https://github.com/superna9999/linux/commit/9c3a95659dd532d186556c1570c54d79ea5a4d45
>
GX is incapable of OEN. To be on par with it ,we have to pullup/down clk
pin as
you did at[1].
>> static const struct meson_spicc_data meson_spicc_gx_data = {
>> - .max_speed_hz = 30000000,
>> + .max_speed_hz = 30000000,
>
> Nitpick, but I would have kept the indentation here ...
>
>> };
>>
>> static const struct meson_spicc_data meson_spicc_axg_data = {
>> - .max_speed_hz = 80000000,
>> + .max_speed_hz = 80000000,
>> + .has_oen = true,
>
> same here
>
> Anywy it's nitpick,
>
ok, i will revert it next patch.
next prev parent reply other threads:[~2018-12-13 13:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 8:39 [PATCH v2 0/3] spi: meson-axg: add few enhanced features Sunny Luo
2018-12-13 8:39 ` [PATCH v2 1/3] spi: meson-axg: support MAX 80M clock Sunny Luo
2018-12-13 8:49 ` Neil Armstrong
2018-12-13 11:55 ` Sunny Luo
2018-12-13 8:39 ` [PATCH v2 2/3] spi: meson-axg: enhance output enable feature Sunny Luo
2018-12-13 8:53 ` Neil Armstrong
2018-12-13 13:12 ` Sunny Luo [this message]
2018-12-13 9:04 ` Jerome Brunet
2018-12-13 11:53 ` Mark Brown
2018-12-13 12:50 ` Sunny Luo
2018-12-13 13:31 ` Sunny Luo
2018-12-13 8:39 ` [PATCH v2 3/3] spi: meson-axg: add a linear clock divider support Sunny Luo
2018-12-13 8:55 ` Neil Armstrong
2018-12-13 9:28 ` Jerome Brunet
2018-12-13 14:37 ` Sunny Luo
2018-12-13 15:01 ` Jerome Brunet
2018-12-13 13:25 ` Sunny Luo
2018-12-15 18:31 ` kbuild test robot
[not found] ` <1544690354-16409-1-git-send-email-sunny.luo-LpR1jeaWuhtBDgjK7y7TUQ@public.gmane.org>
2020-02-19 8:17 ` [PATCH v2 0/3] spi: meson-axg: add few enhanced features Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c85195d4-29e5-0e66-da09-cb86248660a3@amlogic.com \
--to=sunny.luo@amlogic.com \
--cc=broonie@kernel.org \
--cc=carlo@caione.org \
--cc=jbrunet@baylibre.com \
--cc=jianxin.pan@amlogic.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=xingyu.chen@amlogic.com \
--cc=yixun.lan@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).