From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
To: Jean-Hugues Deschenes
<jean-hugues.deschenes-YGVykHU+fedBDgjK7y7TUQ@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
David Brownell
<dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: [PATCH] link dw_spi.o with the kernel objects
Date: Thu, 21 Jan 2010 08:56:15 -0700 [thread overview]
Message-ID: <fa686aa41001210756n358d5ff2ja9bb93a9b37ce9c1@mail.gmail.com> (raw)
In-Reply-To: <4B5877C1.1080605-YGVykHU+fedBDgjK7y7TUQ@public.gmane.org>
On Thu, Jan 21, 2010 at 8:50 AM, Jean-Hugues Deschenes
<jean-hugues.deschenes-YGVykHU+fedBDgjK7y7TUQ@public.gmane.org> wrote:
>
> Grant Likely wrote:
>>
>> On Thu, Jan 21, 2010 at 8:33 AM, Jean-Hugues Deschenes
>> <jean-hugues.deschenes-YGVykHU+fedBDgjK7y7TUQ@public.gmane.org> wrote:
>>
>>>
>>> The bulk of the dw_spi driver is contained in dw_spi.c, which was
>>> statically
>>> linked with the kernel, whether dw_spi_(pci|mmio) was requested to be
>>> built
>>> as a module or not. This patch links dw_spi.o with the kernel module.
>>>
>>
>> Why not just make dw_spi a kernel module on its own?
>>
>
> That would work also.
>
> The reason I see is because dw_spi is useless on its own since it requires a
> "bus interface drver" (dw_spi_(pci|mmio) for the moment)...
... just like all the other common code in the kernel. :-)
Make it a module.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
prev parent reply other threads:[~2010-01-21 15:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 15:33 [PATCH] link dw_spi.o with the kernel objects Jean-Hugues Deschenes
[not found] ` <20100121153254.18310.27155.stgit-PR71IgaHmJalNznWqnLNUK6RkeBMCJyt@public.gmane.org>
2010-01-21 15:41 ` Grant Likely
[not found] ` <fa686aa41001210741m456d6a07x6184f34bc621cc46-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-01-21 15:50 ` Jean-Hugues Deschenes
[not found] ` <4B5877C1.1080605-YGVykHU+fedBDgjK7y7TUQ@public.gmane.org>
2010-01-21 15:56 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa41001210756n358d5ff2ja9bb93a9b37ce9c1@mail.gmail.com \
--to=grant.likely-s3s/wqlpoipyb63q8fvjnq@public.gmane.org \
--cc=dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=jean-hugues.deschenes-YGVykHU+fedBDgjK7y7TUQ@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).