From: ascordeiro <alinesantanacordeiro@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Julia Lawall <julia.lawall@inria.fr>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] Re: [PATCH 1/2] staging: media: atomisp: pci: Correct identation in block of conditional statements in file atomisp_v4l2.c
Date: Wed, 14 Apr 2021 11:51:02 -0300 [thread overview]
Message-ID: <1ae81e5c2380cf928579d5c62360bdd03a6bbc67.camel@gmail.com> (raw)
In-Reply-To: <20210414144502.GW6021@kadam>
Em qua, 2021-04-14 às 17:45 +0300, Dan Carpenter escreveu:
> On Wed, Apr 14, 2021 at 04:39:20PM +0200, Julia Lawall wrote:
> >
> >
> > On Wed, 14 Apr 2021, Dan Carpenter wrote:
> >
> > > On Wed, Apr 14, 2021 at 11:06:02AM -0300, Aline Santana Cordeiro
> > > wrote:
> > > > Correct identation in block of conditional statements.
> > > > The function "v4l2_device_unregister_subdev()" depends on
> > > > the results of the macro function "list_for_each_entry_safe()".
> > > >
> > > > Signed-off-by: Aline Santana Cordeiro <
> > > > alinesantanacordeiro@gmail.com>
> > > > ---
> > > > drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> > > > b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> > > > index 0295e2e..6d853f4 100644
> > > > --- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> > > > +++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> > > > @@ -1178,7 +1178,7 @@ static void
> > > > atomisp_unregister_entities(struct atomisp_device *isp)
> > > > atomisp_mipi_csi2_unregister_entities(&isp-
> > > > >csi2_port[i]);
> > > >
> > > > list_for_each_entry_safe(sd, next, &isp-
> > > > >v4l2_dev.subdevs, list)
> > > > - v4l2_device_unregister_subdev(sd);
> > > > + v4l2_device_unregister_subdev(sd);
> > > >
> > >
> > > It's really more common to use curly braces for list_for_each()
> > > one
> > > liners.
> > >
> > > list_for_each_entry_safe(sd, next, &isp-
> > > >v4l2_dev.subdevs, list) {
> > > v4l2_device_unregister_subdev(sd);
> > > }
> >
> > A quick test with grep shows 4000 lines containing list_for_each
> > that
> > contain no {, out of 15000 lines containing list_for_each in all.
> >
>
> Huh... You're right. Never mind then.
>
> regards,
> dan carpenter
>
Ok then :)
Thank you all,
Aline
next prev parent reply other threads:[~2021-04-14 14:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1618409028.git.alinesantanacordeiro@gmail.com>
2021-04-14 14:06 ` [PATCH 1/2] staging: media: atomisp: pci: Correct identation in block of conditional statements in file atomisp_v4l2.c Aline Santana Cordeiro
2021-04-14 14:30 ` Dan Carpenter
2021-04-14 14:39 ` [Outreachy kernel] " Julia Lawall
2021-04-14 14:45 ` Dan Carpenter
2021-04-14 14:51 ` ascordeiro [this message]
2021-04-14 14:39 ` ascordeiro
2021-04-14 14:06 ` [PATCH 2/2] staging: media: atomisp: pci: Correct identation in block of conditional statements in file atomisp_acc.c Aline Santana Cordeiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ae81e5c2380cf928579d5c62360bdd03a6bbc67.camel@gmail.com \
--to=alinesantanacordeiro@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).