From: Dan Carpenter <dan.carpenter@oracle.com>
To: Len Baker <len.baker@gmx.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Pavel Skripkin <paskripkin@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging/rtl8712: Remove all strcpy() uses in favor of strscpy()
Date: Mon, 19 Jul 2021 08:37:47 +0300 [thread overview]
Message-ID: <20210719053747.GN1931@kadam> (raw)
In-Reply-To: <20210717155145.15041-1-len.baker@gmx.com>
On Sat, Jul 17, 2021 at 05:51:45PM +0200, Len Baker wrote:
> strcpy() performs no bounds checking on the destination buffer. This
> could result in linear overflows beyond the end of the buffer, leading
> to all kinds of misbehaviors. The safe replacement is strscpy().
>
> Signed-off-by: Len Baker <len.baker@gmx.com>
> ---
> drivers/staging/rtl8712/os_intfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c
> index 2214aca09730..9502f6aa5306 100644
> --- a/drivers/staging/rtl8712/os_intfs.c
> +++ b/drivers/staging/rtl8712/os_intfs.c
> @@ -203,7 +203,7 @@ struct net_device *r8712_init_netdev(void)
> if (!pnetdev)
> return NULL;
> if (dev_alloc_name(pnetdev, ifname) < 0) {
> - strcpy(ifname, "wlan%d");
> + strscpy(ifname, "wlan%d", sizeof(ifname));
> dev_alloc_name(pnetdev, ifname);
Not related to your patch but this code is bad. What it does is the
"ifname" can be set as a module parameter. So instead of testing if it
has been set, it uses the checking inside dev_alloc_name() to see if we
can allocate what the user requested. If not then set it to "wlan%d".
If we cannot allocate what the user wants then we should return an
error.
It should do:
if (ifname[0] == '\0')
strscpy(ifname, "wlan%d", sizeof(ifname));
ret = dev_alloc_name(pnetdev, ifname);
if (ret < 0) {
dev_err(pnetdev, "allocating device name failed.\n");
return NULL;
}
regards,
dan carpenter
next prev parent reply other threads:[~2021-07-19 5:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-17 15:51 [PATCH] staging/rtl8712: Remove all strcpy() uses in favor of strscpy() Len Baker
2021-07-19 5:37 ` Dan Carpenter [this message]
2021-07-19 15:24 ` David Laight
2021-07-21 8:06 ` Dan Carpenter
2021-07-23 15:15 ` Len Baker
2021-07-26 8:11 ` Dan Carpenter
2021-07-28 17:45 ` Len Baker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210719053747.GN1931@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=len.baker@gmx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=paskripkin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).