From: Nam Cao <namcaov@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: forest@alittletooquiet.net, gregkh@linuxfoundation.org,
philipp.g.hortmann@gmail.com, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [RFC PATCH 3/5] staging: vt6655: split device_alloc_rx_buf
Date: Tue, 27 Sep 2022 13:39:13 +0200 [thread overview]
Message-ID: <20220927113913.GB10468@nam-dell> (raw)
In-Reply-To: <Yyg4BTymed1fEzQx@kadam>
On Mon, Sep 19, 2022 at 12:36:05PM +0300, Dan Carpenter wrote:
> On Thu, Sep 15, 2022 at 10:29:34PM +0200, Nam Cao wrote:
> > The function device_alloc_rx_buf does 2 things: allocating rx buffer
> > and initializing the rx descriptor's values. Split this function into
> > two, with each does one job.
> >
> > This split is preparation for implementing correct out-of-memory error
> > handling.
> >
> > Signed-off-by: Nam Cao <namcaov@gmail.com>
> > ---
> > drivers/staging/vt6655/device_main.c | 16 +++++++++++++---
> > 1 file changed, 13 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
> > index 79325a693857..27fe28156257 100644
> > --- a/drivers/staging/vt6655/device_main.c
> > +++ b/drivers/staging/vt6655/device_main.c
> > @@ -133,6 +133,7 @@ static int device_init_td1_ring(struct vnt_private *priv);
> > static int device_rx_srv(struct vnt_private *priv, unsigned int idx);
> > static int device_tx_srv(struct vnt_private *priv, unsigned int idx);
> > static bool device_alloc_rx_buf(struct vnt_private *, struct vnt_rx_desc *);
> > +static void device_init_rx_desc(struct vnt_private *priv, struct vnt_rx_desc *rd);
> > static void device_free_rx_buf(struct vnt_private *priv,
> > struct vnt_rx_desc *rd);
> > static void device_init_registers(struct vnt_private *priv);
> > @@ -615,6 +616,8 @@ static int device_init_rd0_ring(struct vnt_private *priv)
> > dev_err(&priv->pcid->dev, "can not alloc rx bufs\n");
> > ret = -ENOMEM;
> > goto err_free_rd;
> > + } else {
> > + device_init_rx_desc(priv, desc);
> > }
>
> None of these else statements make sense. It should be:
>
> ret = -ENOMEM;
> goto err_free_rd;
> }
>
> device_init_rx_desc(priv, desc);
> desc->next = &priv->aRD0Ring[(i + 1) % priv->opts.rx_descs0];
That does look better, will be changed.
> I haven't reviewed the patch totally. I don't understand why it's doing
> this here instead of at the end. But then I don't understand why it
> needs to be in a separate function at all.
>
> This patch does not make sense. The commit description says that this
> is a "preparation" patch. Maybe fold it in with patch 5? The rule is
> "one thing per patch" not "half a thing per patch".
I thought splitting it like this would make it easier to review. But if
these preparation patches are not welcomed, I will squash them and
resend.
Thank you for spending time reviewing the patches.
Best regards,
Nam
next prev parent reply other threads:[~2022-09-27 11:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 20:29 [RFC PATCH 0/5] staging: vt6655: Implement allocation failure handling Nam Cao
2022-09-15 20:29 ` [RFC PATCH 1/5] staging: vt6655: remove redundant if condition Nam Cao
2022-09-15 20:29 ` [RFC PATCH 2/5] staging: vt6655: change vnt_receive_frame return type to void Nam Cao
2022-09-19 9:45 ` Dan Carpenter
2022-09-27 11:36 ` Nam Cao
2022-09-15 20:29 ` [RFC PATCH 3/5] staging: vt6655: split device_alloc_rx_buf Nam Cao
2022-09-19 9:36 ` Dan Carpenter
2022-09-27 11:39 ` Nam Cao [this message]
2022-09-15 20:29 ` [RFC PATCH 4/5] staging: vt6655: change device_alloc_rx_buf's argument Nam Cao
2022-09-15 20:29 ` [RFC PATCH 5/5] staging: vt6655: implement allocation failure handling Nam Cao
2022-09-19 10:12 ` Dan Carpenter
2022-09-27 11:54 ` Nam Cao
2022-09-15 20:58 ` [RFC PATCH 0/5] staging: vt6655: Implement " Philipp Hortmann
2022-09-16 7:11 ` Nam Cao
2022-09-16 7:38 ` Dan Carpenter
2022-09-19 9:36 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220927113913.GB10468@nam-dell \
--to=namcaov@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).