From: Pavel Skripkin <paskripkin@gmail.com>
To: Phillip Potter <phil@philpotter.co.uk>
Cc: Martin Kaiser <lists@kaiser.cx>,
Jiasheng Jiang <jiasheng@iscas.ac.cn>,
dan.carpenter@oracle.com, Larry.Finger@lwfinger.net,
gregkh@linuxfoundation.org, straube.linux@gmail.com,
fmdefrancesco@gmail.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: r8188eu: add check for kzalloc
Date: Sun, 22 May 2022 00:05:34 +0300 [thread overview]
Message-ID: <3e4761a4-5ee8-0ba0-d64c-fe8798f2f010@gmail.com> (raw)
In-Reply-To: <YolRut+PJ68J9mcM@KernelVM>
Hi Phillip,
On 5/21/22 23:56, Phillip Potter wrote:
> Hi Pavel,
>
> I agree with you totally - we should change these semantics to reflect
> how the rest of the kernel generally does things. That said, that is a
> bigger patch set and I noticed the driver was broken before I read this
> thread, so I've submitted a patch already just to fix the breakage for
> now.
>
> Changing these semantics is a bigger patch/patchset and I wanted to get
> this out in the meantime - if you are looking at doing this conversion I
> will by all means leave that alone as no desire to tread on anyones
> toes :-)
>
I think, redoing more then 500 place will take quite a long time, but
driver should be fixed ASAP.
So let's apply your patch and then someone (maybe me) will cook a patch.
With regards,
Pavel Skripkin
next prev parent reply other threads:[~2022-05-21 21:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 7:59 [PATCH v3] staging: r8188eu: add check for kzalloc Jiasheng Jiang
2022-05-18 8:13 ` Dan Carpenter
2022-05-21 15:50 ` Martin Kaiser
2022-05-21 20:26 ` Pavel Skripkin
2022-05-21 20:56 ` Phillip Potter
2022-05-21 21:05 ` Pavel Skripkin [this message]
2022-05-21 21:57 ` Larry Finger
2022-05-24 8:18 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e4761a4-5ee8-0ba0-d64c-fe8798f2f010@gmail.com \
--to=paskripkin@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jiasheng@iscas.ac.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lists@kaiser.cx \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).