Re: [PATCH v2 2/4] staging: r8188eu: add error handling of rtw_read16

From: Pavel Skripkin <paskripkin@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
	straube.linux@gmail.com, dan.carpenter@oracle.com,
	fmdefrancesco@gmail.com, linux-kernel@vger.kernel.org,
	linux-staging@lists.linux.dev
Subject: Re: [PATCH v2 2/4] staging: r8188eu: add error handling of rtw_read16
Date: Mon, 6 Jun 2022 22:00:58 +0300	[thread overview]
Message-ID: <774c3d04-4c02-ed52-f545-73acbffde561@gmail.com> (raw)
In-Reply-To: <Yp2VQU9G1xVw9lHE@kroah.com>

Hi Greg,

On 6/6/22 08:48, Greg KH wrote:
>> diff --git a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
>> index e67ecbd1ba79..6662ebc30f7b 100644
>> --- a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
>> +++ b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
>> @@ -249,11 +249,14 @@ static void efuse_read_phymap_from_txpktbuf(
>>  		hi32 = cpu_to_le32(rtw_read32(adapter, REG_PKTBUF_DBG_DATA_H));
>>  
>>  		if (i == 0) {
>> +			u16 reg;
>> +
>>  			/* Although lenc is only used in a debug statement,
>>  			 * do not remove it as the rtw_read16() call consumes
>>  			 * 2 bytes from the EEPROM source.
>>  			 */
>> -			rtw_read16(adapter, REG_PKTBUF_DBG_DATA_L);
>> +			res = rtw_read16(adapter, REG_PKTBUF_DBG_DATA_L, &reg);
>> +			(void)res;
> 
> Same here, that line isn't ok.
> 
hm, that place is not obvious.

I guess, on-chip EEPROM acts like a FIFO, so this read must be completed 
w/o any errors, so I will simply propagate an error to callers

And will place another "FIXME" for further work :)

thanks,

With regards,
Pavel Skripkin