From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f51.google.com (mail-oo1-f51.google.com [209.85.161.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88BF772 for ; Mon, 14 Jun 2021 09:56:40 +0000 (UTC) Received: by mail-oo1-f51.google.com with SMTP id v17-20020a4aa5110000b0290249d63900faso2519477ook.0 for ; Mon, 14 Jun 2021 02:56:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=17xdYDaXcr1GgYwnSmChvSTc/UXYmZQtZNjoRDgyHAw=; b=cZEhqQwUMi3qA2skVWLwd278vC0Of6ba8gN/ywOqCCPGS2nVuE5tlQ3Ec/BCfmY21k R9Ay7mTCx4f494TfLoQwYgM5qMWjZz4ZeOJ3ThrxH54CT2h1CMfpU+jz69bsTOgXJkJ0 zrm0RAdmF0RWeqH8203uXoRnvqCC21rwONaz07Oeh3aKDJEnWNCUa3E/yUDJCFrBUzzZ lZRtRpgFOAPlGiBe+9NYqJNScFMRNAxGh7yoClYylxwtVqcFa0x9TtP64+gHhr+6yMsS Or8sJAeAZRQI2iEcXsiGCBr2ywyq87AqlR/hEdzHE86ox4DqD2aqHvW4/R9HGK0fRN5K h2qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=17xdYDaXcr1GgYwnSmChvSTc/UXYmZQtZNjoRDgyHAw=; b=YD/Y1WVnyzAR9nvrCnXX/v09+/n7cj3G84L1cI6o0p9Eq2MQTH5ZBmDkYTs7pL8Fyq mLuZdxI/UDODUHxpUElN1xiJM8FDJRlTHuWYHCoRTOl156e7rO1VyNkQpkTSQjdyUJMZ QPsyswkVl1s1VBBo3u76xqQyW+s12g7RIDACZiJ55YEKCk7UQ1mkwAGbICWgE4DIIAU1 KAZJk85hYrRCVL7scAm68mmbaJXOWs+Jj9Ougo5qFqpb2gbLZfTPdQafEhHVVXexsluY mX+5Tit1PPZ/sXBXQ6we0WsFBJDLEFceRYwQU1ISu513hVgtdHpyrYeIr3WbGYySEKQ2 b7TQ== X-Gm-Message-State: AOAM5338/GUS4MYZvDYWoPIKIrnVYaOkR4PuBnDOfqOGBtdayjCDETL/ 87nhNsG/cRiuYtSU/l52fKCY4jrvpdvWKZ+5uFI= X-Google-Smtp-Source: ABdhPJxK+IiZ7hAc2SVBDlCb8Xoaf0kIEdwUnJ0Ua2eG3Zz2A1TApntQ8+Di6xjSdvMmjoD8JVgG2AOZjxp78QuDPs8= X-Received: by 2002:a05:6820:386:: with SMTP id r6mr12312802ooj.25.1623664599826; Mon, 14 Jun 2021 02:56:39 -0700 (PDT) X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20210613155623.17233-1-sergio.paracuellos@gmail.com> <20210613155623.17233-2-sergio.paracuellos@gmail.com> <12f81f6e-41be-7e0f-5590-67591c722a38@gmail.com> In-Reply-To: <12f81f6e-41be-7e0f-5590-67591c722a38@gmail.com> From: Sergio Paracuellos Date: Mon, 14 Jun 2021 11:56:28 +0200 Message-ID: Subject: Re: [PATCH 1/3] MIPS: ralink: Define PCI_IOBASE To: Sergei Shtylyov Cc: linux-staging@lists.linux.dev, Greg KH , NeilBrown , "open list:MIPS" , Thomas Bogendoerfer , Ilya Lipnitskiy , John Crispin Content-Type: text/plain; charset="UTF-8" Hi Sergei, On Mon, Jun 14, 2021 at 11:13 AM Sergei Shtylyov wrote: > > Hello! > > On 13.06.2021 18:56, Sergio Paracuellos wrote: > > > PCI_IOBASE is used to create VM maps for PCI I/O ports, it is > > required by generic PCI drivers to make memory mapped I/O range > > work. Hence define it for ralink architectures to be able to > > avoid parsing manually IO ranges in PCI generic driver code. > > Function 'plat_mem_setup' for ralink is using 'set_io_port_base' > > call using '0xa0000000' as address, so use the same address in > > the definition to align things. > > > > Signed-off-by: Sergio Paracuellos > > --- > > arch/mips/include/asm/mach-ralink/spaces.h | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > create mode 100644 arch/mips/include/asm/mach-ralink/spaces.h > > > > diff --git a/arch/mips/include/asm/mach-ralink/spaces.h b/arch/mips/include/asm/mach-ralink/spaces.h > > new file mode 100644 > > index 000000000000..ec58d4a9ed05 > > --- /dev/null > > +++ b/arch/mips/include/asm/mach-ralink/spaces.h > > @@ -0,0 +1,10 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +#ifndef __ASM_MACH_RALINK_SPACES_H_ > > +#define __ASM_MACH_RALINK_SPACES_H_ > > + > > +#define PCI_IOBASE _AC(0xa0000000, UL) > > +#define PCI_IOSIZE SZ_16M > > +#define IO_SPACE_LIMIT (PCI_IOSIZE - 1) > > Why this sudden switch to spaces for indentation? Previous lines were > (correctly) indented with tabs... I don't really know what could have happened, honestly. I will fix spaces into tabs and send v2. > > > + > > +#include > > +#endif > > MBR, Sergei Best regards, Sergio Paracuellos