From: Greg KH <gregkh@linuxfoundation.org>
To: Zhansaya Bagdauletkyzy <zhansayabagdaulet@gmail.com>
Cc: johan@kernel.org, elder@kernel.org, greybus-dev@lists.linaro.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] staging: greybus: Match parentheses alignment
Date: Tue, 6 Apr 2021 15:27:08 +0200 [thread overview]
Message-ID: <YGxhrLZPIPjILWUH@kroah.com> (raw)
In-Reply-To: <20210406124259.GA96537@zhans>
On Tue, Apr 06, 2021 at 06:42:59PM +0600, Zhansaya Bagdauletkyzy wrote:
> Match next line with open parentheses by adding tabs/spaces
> to conform with Linux kernel coding style.
> Reported by checkpatch.
>
> Signed-off-by: Zhansaya Bagdauletkyzy <zhansayabagdaulet@gmail.com>
> ---
> drivers/staging/greybus/camera.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c
> index cdbb42cd413b..5dca585694c0 100644
> --- a/drivers/staging/greybus/camera.c
> +++ b/drivers/staging/greybus/camera.c
> @@ -220,7 +220,7 @@ static int gb_camera_operation_sync_flags(struct gb_connection *connection,
> }
>
> static int gb_camera_get_max_pkt_size(struct gb_camera *gcam,
> - struct gb_camera_configure_streams_response *resp)
> + struct gb_camera_configure_streams_response *resp)
> {
> unsigned int max_pkt_size = 0;
> unsigned int i;
> @@ -378,8 +378,8 @@ struct ap_csi_config_request {
> #define GB_CAMERA_CSI_CLK_FREQ_MARGIN 150000000U
>
> static int gb_camera_setup_data_connection(struct gb_camera *gcam,
> - struct gb_camera_configure_streams_response *resp,
> - struct gb_camera_csi_params *csi_params)
> + struct gb_camera_configure_streams_response *resp,
> + struct gb_camera_csi_params *csi_params)
And now you violate another coding style requirement, which means
someone will send another patch to fix that up and around and around it
goes...
Sorry, not going to take this.
greg k-h
next prev parent reply other threads:[~2021-04-06 13:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 12:42 [PATCH] staging: greybus: Match parentheses alignment Zhansaya Bagdauletkyzy
2021-04-06 13:27 ` Greg KH [this message]
2021-04-06 17:21 ` Joe Perches
2021-04-14 13:17 ` Alex Elder
2021-04-14 14:29 ` Joe Perches
2021-04-14 14:35 ` Alex Elder
2021-04-14 16:11 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGxhrLZPIPjILWUH@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=elder@kernel.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy-kernel@googlegroups.com \
--cc=zhansayabagdaulet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).