From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 233429445 for ; Mon, 15 Apr 2024 14:51:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713192662; cv=none; b=FobfSffF0rFtU/jAHYe5k+HtS5d5WPfRahbS9CvEzHcSom98MWxmA87GnjuEiaS0xpV8QPRciqbZS7DRmFl2DQI5pbzxm9yllhNKsOFrsPM75rt21/Z2Dhnf2O1n90jG5mw4B605A79Dq0aXoAvVnoYpeun51HvIt1Q63yYC3Lo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713192662; c=relaxed/simple; bh=FViy2vf9oyiBlDzPB1JuRggbF7n1kNyWG01Gxvl2PZc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hg1VI+3OzGvzo5iI5MEXjjtwX3SOP1qiOAHHA4qwd44sQxLpicl2Av+GD040/wB/Q4mDBaFKyB+z0tc1PHl/eI4vKukHxLWR33hlQeH8OnXDfKLLRnItYQ31KaTaBP84s7aBLSG7XZVRabiwBi5T1IncK//uy0JvoMlJLMPZ+/s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=fail smtp.mailfrom=kernel.org; arc=none smtp.client-ip=192.198.163.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=kernel.org X-CSE-ConnectionGUID: WXfcz68rTfyvY2s26nrgaw== X-CSE-MsgGUID: UjG0C9/3Q4OMchnXparRww== X-IronPort-AV: E=McAfee;i="6600,9927,11045"; a="8447852" X-IronPort-AV: E=Sophos;i="6.07,203,1708416000"; d="scan'208";a="8447852" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2024 07:51:01 -0700 X-CSE-ConnectionGUID: XF4vqvLfR3O8TwVhxs54Zg== X-CSE-MsgGUID: 8eN5oh0+TZyGhL4iQ1/Ofw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,203,1708416000"; d="scan'208";a="53133969" Received: from smile.fi.intel.com ([10.237.72.54]) by fmviesa001.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2024 07:50:58 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rwNfb-00000004RBO-3rWl; Mon, 15 Apr 2024 17:50:55 +0300 Date: Mon, 15 Apr 2024 17:50:55 +0300 From: Andy Shevchenko To: Hans de Goede Cc: Sakari Ailus , Mauro Carvalho Chehab , Kate Hsuan , Tsuchiya Yuto , Fabio Aiuto , linux-media@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH 13/23] media: atomisp: Drop the atomisp custom lm3554 flash driver Message-ID: References: <20240415120220.219480-1-hdegoede@redhat.com> <20240415120220.219480-14-hdegoede@redhat.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Mon, Apr 15, 2024 at 05:49:33PM +0300, Andy Shevchenko wrote: > On Mon, Apr 15, 2024 at 02:02:10PM +0200, Hans de Goede wrote: > > Drop the atomisp custom lm3554 flash driver, support for flash drivers > > using the custom atomisp flash interface is going to be removed from > > the atomisp driver. > > > > If flash supports for the lm3554 turns out to be necessary on some > > atomisp devices in the future then this should be re-implemented > > using the new include/linux/led-class-flash.h APIs. > > > > The atomisp specific lm3554 driver could still be usable as a reference > > for how to use / driver the lm3554 for a future re-implementation > > using standardized APIs, but for that it can be retrieved from > > the git history. > > FYI: The driver is already there as drivers/leds/leds-lm355x.c. > It might still need the binding to v4l2 subsystem, but still... Wow, it even *was* there when AtomISP has been added: commit b98d13c725920e9ab7696e0d7d19c4db1bdf6737 Author: G.Shark Jeong Date: Wed Sep 5 15:05:58 2012 +0800 -- With Best Regards, Andy Shevchenko