From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55CE8173 for ; Wed, 23 Jun 2021 16:09:26 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 6530961002; Wed, 23 Jun 2021 16:09:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624464565; bh=thhgwnhMO2xnAWqL7Ceox1dUfMDGS5PkB8ZPYFsW+Fc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Gu6bEqeuBDd6kTGAAeS5YwKMnpgcqWz9UE7gsSVW4/F0+fMWe8oQFI2UhkoY9qKM1 4Yg3QU1nggRKhyPNVrycrtp8teyKYZVI/q+XM16WX6MBmLdu8RcQpa5Vzj4KoH0YxO /+E4ys+ccn5pQZN/wT224ZRIgtqIh2DfPjth4o8LMnmRYjH4tzcCoaxjusrOYETv+L WAN5d8y4O9KnQ8KK3+RpT5Q9mj+aPp6oBqBcDCrnOOvd7aRYKXP0uWuoMxz66Z8DFi h9CbFmmBI8YFbm4JQhHprqZ2ysZA+8PYLKxj1r5W3iOT4bHDxsHSSL5pBdXQfRHiHk K1gZmYKZt+ZYw== From: Mark Brown To: linux-spi@vger.kernel.org, Ralf Schlatterbeck , Mirko Vogt , linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Maxime Ripard , linux-arm-kernel@lists.infradead.org, Jernej Skrabec , Chen-Yu Tsai Cc: Mark Brown Subject: Re: [PATCH v2 1/1] spi: spi-sun6i: Fix chipselect/clock bug Date: Wed, 23 Jun 2021 17:08:50 +0100 Message-Id: <162446446389.55587.4675699927821368249.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210614144507.y3udezjfbko7eavv@runtux.com> References: <20210614144507.y3udezjfbko7eavv@runtux.com> X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Mon, 14 Jun 2021 16:45:07 +0200, Ralf Schlatterbeck wrote: > The current sun6i SPI implementation initializes the transfer too early, > resulting in SCK going high before the transfer. When using an additional > (gpio) chipselect with sun6i, the chipselect is asserted at a time when > clock is high, making the SPI transfer fail. > > This is due to SUN6I_GBL_CTL_BUS_ENABLE being written into > SUN6I_GBL_CTL_REG at an early stage. Moving that to the transfer > function, hence, right before the transfer starts, mitigates that > problem. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: spi-sun6i: Fix chipselect/clock bug commit: 0d7993b234c9fad8cb6bec6adfaa74694ba85ecb All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark