From: Rob Herring <robh@kernel.org>
To: Sameer Pujar <spujar@nvidia.com>
Cc: broonie@kernel.org, lgirdwood@gmail.com,
kuninori.morimoto.gx@renesas.com,
pierre-louis.bossart@linux.intel.com, perex@perex.cz,
tiwai@suse.com, p.zabel@pengutronix.de, thierry.reding@gmail.com,
jonathanh@nvidia.com, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, sharadg@nvidia.com,
mkumard@nvidia.com, viswanathl@nvidia.com, rlokhande@nvidia.com,
dramesh@nvidia.com, atalambedu@nvidia.com, nwartikar@nvidia.com,
swarren@nvidia.com, nicoleotsuka@gmail.com
Subject: Re: [PATCH v4 10/15] ASoC: dt-bindings: tegra: Add graph bindings
Date: Mon, 19 Oct 2020 17:11:05 -0500 [thread overview]
Message-ID: <20201019221105.GA3679866@bogus> (raw)
In-Reply-To: <1602859382-19505-11-git-send-email-spujar@nvidia.com>
On Fri, Oct 16, 2020 at 08:12:57PM +0530, Sameer Pujar wrote:
> Add device tree binding properties of generic graph to ASoC component
> devices. This allows to define audio ports out of these components or
> DAIs and audio graph based sound card can be realised with this.
>
> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
> ---
> Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml | 7 +++++++
> .../devicetree/bindings/sound/nvidia,tegra210-admaif.yaml | 7 +++++++
> Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml | 7 +++++++
> Documentation/devicetree/bindings/sound/nvidia,tegra210-dmic.yaml | 7 +++++++
> Documentation/devicetree/bindings/sound/nvidia,tegra210-i2s.yaml | 7 +++++++
> 5 files changed, 35 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml
> index ed2fb32..23875b1 100644
> --- a/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml
> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml
> @@ -55,6 +55,13 @@ properties:
> The name can be "DSPK1" or "DSPKx", where x depends on the maximum
> available instances on a Tegra SoC.
>
> + ports:
> + $ref: /schemas/sound/audio-graph-card.yaml#/definitions/ports
> +
> +patternProperties:
> + "^port(@[0-9a-f]+)?$":
> + $ref: /schemas/sound/audio-graph-card.yaml#/definitions/port
You should have either 'ports' or a single 'port' (yes, the graph
binding allowed multiple port nodes without 'ports', but that should be
deprecated IMO)
next prev parent reply other threads:[~2020-10-19 22:11 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 14:42 [PATCH v4 00/15] Audio graph card updates and usage with Tegra210 audio Sameer Pujar
2020-10-16 14:42 ` [PATCH v4 01/15] ASoC: soc-core: Fix component name_prefix parsing Sameer Pujar
2020-10-16 14:42 ` [PATCH v4 02/15] ASoC: soc-pcm: Get all BEs along DAPM path Sameer Pujar
2020-10-16 14:42 ` [PATCH v4 03/15] ASoC: audio-graph: Use of_node and DAI for DPCM DAI link names Sameer Pujar
2020-10-16 14:42 ` [PATCH v4 04/15] ASoC: audio-graph: Identify 'no_pcm' DAI links for DPCM Sameer Pujar
2020-10-16 14:42 ` [PATCH v4 05/15] ASoC: audio-graph: Support empty Codec endpoint Sameer Pujar
2020-10-16 14:42 ` [PATCH v4 06/15] ASoC: audio-graph: Expose new members for asoc_simple_priv Sameer Pujar
2020-10-16 14:42 ` [PATCH v4 07/15] ASoC: audio-graph: Expose helpers from audio graph Sameer Pujar
2020-10-16 14:42 ` [PATCH v4 08/15] Documentation: of: Convert graph bindings to json-schema Sameer Pujar
2020-10-19 21:56 ` Rob Herring
2020-10-20 5:34 ` Sameer Pujar
2020-10-20 8:30 ` Philipp Zabel
2020-10-23 13:45 ` Sameer Pujar
2020-10-16 14:42 ` [PATCH v4 09/15] ASoC: dt-bindings: audio-graph: Convert " Sameer Pujar
2020-10-19 2:50 ` Kuninori Morimoto
2020-10-19 4:30 ` Sameer Pujar
2020-10-19 4:41 ` Kuninori Morimoto
2020-10-19 22:11 ` Rob Herring
2020-10-16 14:42 ` [PATCH v4 10/15] ASoC: dt-bindings: tegra: Add graph bindings Sameer Pujar
2020-10-19 22:11 ` Rob Herring [this message]
2020-10-20 6:03 ` Sameer Pujar
2020-10-16 14:42 ` [PATCH v4 11/15] ASoC: dt-bindings: tegra: Add json-schema for Tegra audio graph card Sameer Pujar
2020-10-19 22:16 ` Rob Herring
2020-10-20 6:16 ` Sameer Pujar
2020-10-20 13:24 ` Rob Herring
2020-10-16 14:42 ` [PATCH v4 12/15] ASoC: tegra: Add audio graph based card driver Sameer Pujar
2020-10-16 14:43 ` [PATCH v4 13/15] arm64: defconfig: Enable Tegra audio graph " Sameer Pujar
2020-10-16 14:43 ` [PATCH v4 14/15] arm64: tegra: Audio graph header for Tegra210 Sameer Pujar
2020-10-16 14:43 ` [PATCH v4 15/15] arm64: tegra: Audio graph sound card for Jetson Nano and TX1 Sameer Pujar
2020-10-30 6:34 ` [PATCH v4 00/15] Audio graph card updates and usage with Tegra210 audio Sameer Pujar
2020-10-30 13:58 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201019221105.GA3679866@bogus \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=atalambedu@nvidia.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dramesh@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkumard@nvidia.com \
--cc=nicoleotsuka@gmail.com \
--cc=nwartikar@nvidia.com \
--cc=p.zabel@pengutronix.de \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rlokhande@nvidia.com \
--cc=sharadg@nvidia.com \
--cc=spujar@nvidia.com \
--cc=swarren@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
--cc=viswanathl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).