From: Jon Hunter <jonathanh@nvidia.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: tegra: drop serial clock-names and reset-names
Date: Wed, 28 Jun 2023 10:58:52 +0100 [thread overview]
Message-ID: <55cece9b-b4b8-854c-f948-2e30895f36b0@nvidia.com> (raw)
In-Reply-To: <20230123151543.369724-1-krzysztof.kozlowski@linaro.org>
On 23/01/2023 15:15, Krzysztof Kozlowski wrote:
> The serial node does not use clock-names and reset-names:
>
> tegra234-sim-vdk.dtb: serial@3100000: Unevaluated properties are not allowed ('clock-names', 'reset-names' were unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> arch/arm64/boot/dts/nvidia/tegra132.dtsi | 8 --------
> arch/arm64/boot/dts/nvidia/tegra186.dtsi | 2 --
> arch/arm64/boot/dts/nvidia/tegra194.dtsi | 4 ----
> arch/arm64/boot/dts/nvidia/tegra210.dtsi | 8 --------
> arch/arm64/boot/dts/nvidia/tegra234.dtsi | 2 --
> 5 files changed, 24 deletions(-)
...
> diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> index b54353f31df5..372be226a7f4 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> @@ -676,9 +676,7 @@ uarta: serial@3100000 {
> reg = <0x0 0x03100000 0x0 0x10000>;
> interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&bpmp TEGRA234_CLK_UARTA>;
> - clock-names = "serial";
> resets = <&bpmp TEGRA234_RESET_UARTA>;
> - reset-names = "serial";
> status = "disabled";
> };
>
Thierry, do you have a patch to convert the Documentation/devicetree/bindings/serial/nvidia,tegra20-hsuart.txt to yaml? I have noticed that the above change now cause the hsuart to fail on Tegra234 ...
[ 5.109961] serial-tegra 3100000.serial: Couldn't get the reset
[ 5.116302] serial-tegra: probe of 3100000.serial failed with error -2
The drivers/tty/serial/serial-tegra.c driver is making the following call ...
tup->rst = devm_reset_control_get_exclusive(&pdev->dev, "serial");
May be the correct fix for this would be to populate the reset-names in ...
diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
index cd13cf2381dd..513cc2cd0b66 100644
--- a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
+++ b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
@@ -2010,6 +2010,7 @@ interrupt-controller@2a40000 {
serial@3100000 {
compatible = "nvidia,tegra194-hsuart";
+ reset-names = "serial";
status = "okay";
};
I can send a patch.
Jon
--
nvpublic
next prev parent reply other threads:[~2023-06-28 10:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 15:15 [PATCH] arm64: dts: tegra: drop serial clock-names and reset-names Krzysztof Kozlowski
2023-03-12 16:59 ` Krzysztof Kozlowski
2023-03-22 19:22 ` Krzysztof Kozlowski
2023-03-23 8:34 ` Thierry Reding
2023-03-23 8:37 ` Thierry Reding
2023-06-28 9:58 ` Jon Hunter [this message]
2023-07-01 8:14 ` Krzysztof Kozlowski
2023-07-03 9:58 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55cece9b-b4b8-854c-f948-2e30895f36b0@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).