From: Jon Hunter <jonathanh@nvidia.com>
To: Saravana Kannan <saravanak@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>
Cc: <kernel-team@android.com>, <linux-kernel@vger.kernel.org>,
Jisheng Zhang <Jisheng.Zhang@synaptics.com>,
Kevin Hilman <khilman@baylibre.com>,
John Stultz <john.stultz@linaro.org>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Marc Zyngier <maz@kernel.org>,
linux-tegra <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH v1 0/5] Enable fw_devlink=on by default
Date: Wed, 13 Jan 2021 11:30:16 +0000 [thread overview]
Message-ID: <56f7d032-ba5a-a8c7-23de-2969d98c527e@nvidia.com> (raw)
In-Reply-To: <20201218031703.3053753-1-saravanak@google.com>
On 18/12/2020 03:16, Saravana Kannan wrote:
> As discussed in LPC 2020, cyclic dependencies in firmware that couldn't
> be broken using logic was one of the last remaining reasons
> fw_devlink=on couldn't be set by default.
>
> This series changes fw_devlink so that when a cyclic dependency is found
> in firmware, the links between those devices fallback to permissive mode
> behavior. This way, the rest of the system still benefits from
> fw_devlink, but the ambiguous cases fallback to permissive mode.
>
> Setting fw_devlink=on by default brings a bunch of benefits (currently,
> only for systems with device tree firmware):
> * Significantly cuts down deferred probes.
> * Device probe is effectively attempted in graph order.
> * Makes it much easier to load drivers as modules without having to
> worry about functional dependencies between modules (depmod is still
> needed for symbol dependencies).
One issue we have come across with this is the of_mdio.c driver. On
Tegra194 Jetson Xavier I am seeing the following ...
boot: logs: [ 4.194791] WARNING KERN WARNING: CPU: 0 PID: 1 at /dvs/git/dirty/git-master_l4t-upstream/kernel/drivers/base/core.c:1189 device_links_driver_bound+0x240/0x260
boot: logs: [ 4.207683] WARNING KERN Modules linked in:
boot: logs: [ 4.210691] WARNING KERN CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.11.0-rc3-next-20210112-gdf869cab4b35 #1
boot: logs: [ 4.219221] WARNING KERN Hardware name: NVIDIA Jetson AGX Xavier Developer Kit (DT)
boot: logs: [ 4.225628] WARNING KERN pstate: 80400009 (Nzcv daif +PAN -UAO -TCO BTYPE=--)
boot: logs: [ 4.231542] WARNING KERN pc : device_links_driver_bound+0x240/0x260
boot: logs: [ 4.236587] WARNING KERN lr : device_links_driver_bound+0xf8/0x260
boot: logs: [ 4.241560] WARNING KERN sp : ffff800011f4b980
boot: logs: [ 4.244819] WARNING KERN x29: ffff800011f4b980 x28: ffff00008208a0a0
boot: logs: [ 4.250051] WARNING KERN x27: ffff00008208a080 x26: 00000000ffffffff
boot: logs: [ 4.255271] WARNING KERN x25: 0000000000000003 x24: ffff800011b99000
boot: logs: [ 4.260489] WARNING KERN x23: 0000000000000001 x22: ffff800011df14f0
boot: logs: [ 4.265706] WARNING KERN x21: ffff800011f4b9f8 x20: ffff800011df1000
boot: logs: [ 4.270934] WARNING KERN x19: ffff00008208a000 x18: 0000000000000005
boot: logs: [ 4.276166] WARNING KERN x17: 0000000000000007 x16: 0000000000000001
boot: logs: [ 4.281382] WARNING KERN x15: ffff000080030c90 x14: ffff0000805c9df8
boot: logs: [ 4.286618] WARNING KERN x13: 0000000000000000 x12: ffff000080030c90
boot: logs: [ 4.291847] WARNING KERN x11: ffff0000805c9da8 x10: 0000000000000040
boot: logs: [ 4.297061] WARNING KERN x9 : ffff000080030c98 x8 : 0000000000000000
boot: logs: [ 4.302291] WARNING KERN x7 : 0000000000000009 x6 : 0000000000000000
boot: logs: [ 4.307509] WARNING KERN x5 : ffff000080100000 x4 : 0000000000000000
boot: logs: [ 4.312739] WARNING KERN x3 : ffff800011df1e38 x2 : ffff000080908c10
boot: logs: [ 4.317956] WARNING KERN x1 : 0000000000000001 x0 : ffff0000809ca400
boot: logs: [ 4.323183] WARNING KERN Call trace:
boot: logs: [ 4.325593] WARNING KERN device_links_driver_bound+0x240/0x260
boot: logs: [ 4.330301] WARNING KERN driver_bound+0x70/0xd0
boot: logs: [ 4.333740] WARNING KERN device_bind_driver+0x50/0x60
boot: logs: [ 4.337671] WARNING KERN phy_attach_direct+0x258/0x2e0
boot: logs: [ 4.341718] WARNING KERN phylink_of_phy_connect+0x7c/0x140
boot: logs: [ 4.346081] WARNING KERN stmmac_open+0xb04/0xc70
boot: logs: [ 4.349612] WARNING KERN __dev_open+0xe0/0x190
boot: logs: [ 4.352972] WARNING KERN __dev_change_flags+0x16c/0x1b8
boot: logs: [ 4.357081] WARNING KERN dev_change_flags+0x20/0x60
boot: logs: [ 4.360856] WARNING KERN ip_auto_config+0x2a0/0xfe8
boot: logs: [ 4.364633] WARNING KERN do_one_initcall+0x58/0x1b8
boot: logs: [ 4.368405] WARNING KERN kernel_init_freeable+0x1ec/0x240
boot: logs: [ 4.372698] WARNING KERN kernel_init+0x10/0x110
boot: logs: [ 4.376130] WARNING KERN ret_from_fork+0x10/0x18
So looking at this change does this mean that the of_mdio needs to be
converted to a proper driver? I would have thought that this will be
seen on several platforms.
Cheers
Jon
--
nvpublic
next parent reply other threads:[~2021-01-13 11:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201218031703.3053753-1-saravanak@google.com>
2021-01-13 11:30 ` Jon Hunter [this message]
2021-01-13 21:26 ` [PATCH v1 0/5] Enable fw_devlink=on by default Saravana Kannan
2021-01-14 16:11 ` Jon Hunter
2021-01-14 16:47 ` Saravana Kannan
2021-01-14 16:56 ` Jon Hunter
2021-01-28 15:03 ` Jon Hunter
2021-01-28 17:27 ` Saravana Kannan
2021-02-11 0:02 ` Saravana Kannan
2021-02-11 15:03 ` Rafael J. Wysocki
2021-02-11 17:14 ` Saravana Kannan
2021-02-11 17:48 ` Rafael J. Wysocki
2021-02-12 3:04 ` Saravana Kannan
[not found] ` <X/dpkgTnUk+inKHK@kroah.com>
[not found] ` <e28e1f38d87c12a3c714a6573beba6e1@kernel.org>
2021-01-13 15:27 ` Jon Hunter
2021-01-13 21:29 ` Saravana Kannan
2021-01-14 11:34 ` Jon Hunter
2021-01-14 16:40 ` Saravana Kannan
2021-01-14 16:47 ` Jon Hunter
2021-01-14 16:52 ` Saravana Kannan
2021-01-14 18:55 ` Jon Hunter
2021-01-14 21:50 ` Saravana Kannan
2021-01-15 16:12 ` Jon Hunter
2021-01-15 17:44 ` Saravana Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56f7d032-ba5a-a8c7-23de-2969d98c527e@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=Jisheng.Zhang@synaptics.com \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=kernel-team@android.com \
--cc=khilman@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=maz@kernel.org \
--cc=nsaenzjulienne@suse.de \
--cc=rafael@kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).