From: Jon Hunter <jonathanh@nvidia.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-tegra@vger.kernel.org
Subject: Re: [PATCH] soc/tegra: pmc: Add EQOS wake event for Tegra194 and Tegra234
Date: Tue, 9 Apr 2024 08:20:01 +0100 [thread overview]
Message-ID: <6c32386e-324e-4351-a22b-43c801a88239@nvidia.com> (raw)
In-Reply-To: <D0EV7AKFJ1G4.1EED57H68IKH@gmail.com>
On 08/04/2024 17:00, Thierry Reding wrote:
> On Wed Apr 3, 2024 at 1:42 PM CEST, Jon Hunter wrote:
>> Add the wake event for the EQOS ethernet controller on Tegra194 and
>> Tegra234 devices, so that system can be woken up by an event from this
>> ethernet controller.
>>
>> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
>> ---
>> drivers/soc/tegra/pmc.c | 2 ++
>> 1 file changed, 2 insertions(+)
>
> I don't think we've ever tested the EQOS on Tegra234 because all of the
> upstream-supported platforms only make use of the MGBE. Do we have any
> platforms where we need this on Tegra234? Also, do we perhaps want to
> add an wake event for MGBE?
Yes, the Drive platforms [0] support EQOS for Tegra234. Although there
is no device-tree upstream for Drive, I think that it is good to include
this. Obviously we should have it for the Tegra194 platforms that are
upstream and so we may as well included Tegra234.
BTW, we already have the MGBE wake-up event upstream for Tegra234 [1]
and from what I can tell this is the only wake-up event that is
currently missing.
Jon
[0] https://developer.nvidia.com/drive/agx
[1] cc026ccdd502 ("soc/tegra: pmc: Add wake source interrupt for MGBE")
--
nvpublic
next prev parent reply other threads:[~2024-04-09 7:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 11:42 [PATCH] soc/tegra: pmc: Add EQOS wake event for Tegra194 and Tegra234 Jon Hunter
2024-04-08 16:00 ` Thierry Reding
2024-04-09 7:20 ` Jon Hunter [this message]
2024-04-26 15:41 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c32386e-324e-4351-a22b-43c801a88239@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).