From: Thierry Reding <thierry.reding@gmail.com>
To: Sumit Gupta <sumitg@nvidia.com>
Cc: treding@nvidia.com, krzysztof.kozlowski@linaro.org,
dmitry.osipenko@collabora.com, viresh.kumar@linaro.org,
rafael@kernel.org, jonathanh@nvidia.com, robh+dt@kernel.org,
lpieralisi@kernel.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-pci@vger.kernel.org,
mmaddireddy@nvidia.com, kw@linux.com, bhelgaas@google.com,
vidyas@nvidia.com, sanjayc@nvidia.com, ksitaraman@nvidia.com,
ishah@nvidia.com, bbasu@nvidia.com
Subject: Re: [Patch v4 01/10] dt-bindings: memory: tegra: add bpmp ref in tegra234-mc node
Date: Tue, 28 Mar 2023 12:42:00 +0200 [thread overview]
Message-ID: <ZCLEeABPtzXqpZdY@orome> (raw)
In-Reply-To: <20230327161426.32639-2-sumitg@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1529 bytes --]
On Mon, Mar 27, 2023 at 09:44:17PM +0530, Sumit Gupta wrote:
> For Tegra234, add the "nvidia,bpmp" property within the Memory
> Controller (MC) node to reference BPMP node. This is needed in
> the MC driver to pass the client info to the BPMP-FW when memory
> interconnect support is available.
>
> Signed-off-by: Sumit Gupta <sumitg@nvidia.com>
> ---
> .../bindings/memory-controllers/nvidia,tegra186-mc.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra186-mc.yaml b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra186-mc.yaml
> index 935d63d181d9..398d27bb2373 100644
> --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra186-mc.yaml
> +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra186-mc.yaml
> @@ -58,6 +58,10 @@ properties:
> "#interconnect-cells":
> const: 1
>
> + nvidia,bpmp:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: phandle of the node representing the BPMP
> +
> patternProperties:
> "^external-memory-controller@[0-9a-f]+$":
> description:
> @@ -220,6 +224,9 @@ allOf:
> - const: ch14
> - const: ch15
>
> + nvidia,bpmp:
> + description: phandle of the node representing the BPMP
> +
Why do we need this one? There's already an nvidia,bpmp phandle defined
in the patternProperties section for external memory controllers.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-03-28 10:42 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 16:14 [Patch v4 00/10] Tegra234 Memory interconnect support Sumit Gupta
2023-03-27 16:14 ` [Patch v4 01/10] dt-bindings: memory: tegra: add bpmp ref in tegra234-mc node Sumit Gupta
2023-03-28 7:23 ` Krzysztof Kozlowski
2023-03-28 10:48 ` Thierry Reding
2023-03-28 11:22 ` Krzysztof Kozlowski
2023-03-28 12:48 ` Thierry Reding
2023-03-29 17:12 ` Sumit Gupta
2023-04-02 10:47 ` Krzysztof Kozlowski
2023-04-04 11:44 ` Thierry Reding
2023-03-28 10:42 ` Thierry Reding [this message]
2023-03-27 16:14 ` [Patch v4 02/10] arm64: " Sumit Gupta
2023-03-28 7:21 ` Krzysztof Kozlowski
2023-03-28 12:41 ` Sumit Gupta
2023-03-27 16:14 ` [Patch v4 03/10] memory: tegra: add interconnect support for DRAM scaling in Tegra234 Sumit Gupta
2023-03-28 7:31 ` Krzysztof Kozlowski
2023-03-28 11:05 ` Thierry Reding
2023-03-28 12:30 ` Sumit Gupta
2023-03-28 12:34 ` Sumit Gupta
2023-03-27 16:14 ` [Patch v4 04/10] memory: tegra: add mc clients for Tegra234 Sumit Gupta
2023-03-27 16:14 ` [Patch v4 05/10] memory: tegra: add software mc clients in Tegra234 Sumit Gupta
2023-03-27 16:14 ` [Patch v4 06/10] dt-bindings: tegra: add icc ids for dummy MC clients Sumit Gupta
2023-03-27 16:14 ` [Patch v4 07/10] arm64: tegra: Add cpu OPP tables and interconnects property Sumit Gupta
2023-03-27 16:14 ` [Patch v4 08/10] cpufreq: tegra194: add OPP support and set bandwidth Sumit Gupta
2023-03-27 16:14 ` [Patch v4 09/10] memory: tegra: make cpu cluster bw request a multiple of mc channels Sumit Gupta
2023-03-27 16:14 ` [Patch v4 10/10] PCI: tegra194: add interconnect support in Tegra234 Sumit Gupta
2023-03-28 17:53 ` Bjorn Helgaas
2023-03-29 9:14 ` Sumit Gupta
2023-03-29 16:59 ` Bjorn Helgaas
2023-03-29 17:58 ` Sumit Gupta
2023-03-29 19:17 ` Bjorn Helgaas
2023-03-30 8:00 ` Sumit Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCLEeABPtzXqpZdY@orome \
--to=thierry.reding@gmail.com \
--cc=bbasu@nvidia.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.osipenko@collabora.com \
--cc=ishah@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=ksitaraman@nvidia.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mmaddireddy@nvidia.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sanjayc@nvidia.com \
--cc=sumitg@nvidia.com \
--cc=treding@nvidia.com \
--cc=vidyas@nvidia.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).