From: Dmitry Osipenko <digetx@gmail.com>
To: Sowjanya Komatineni <skomatineni@nvidia.com>,
Thierry Reding <thierry.reding@gmail.com>
Cc: jonathanh@nvidia.com, frankc@nvidia.com, hverkuil@xs4all.nl,
sakari.ailus@iki.fi, robh+dt@kernel.org,
helen.koike@collabora.com, gregkh@linuxfoundation.org,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 08/10] gpu: host1x: mipi: Keep MIPI clock enabled till calibration is done
Date: Thu, 6 Aug 2020 19:10:51 +0300 [thread overview]
Message-ID: <b5612e93-f1c4-4762-baa1-5d85eb1edbe1@gmail.com> (raw)
In-Reply-To: <4f15d655-3d62-cf9f-82da-eae379d60fa6@nvidia.com>
06.08.2020 18:59, Sowjanya Komatineni пишет:
...
>>> Confirmed from HW designer, calibration FSM to finish takes worst case
>>> 72uS so by the time it gets to sensor stream it will be done its
>>> sequence and will be waiting for DONE bit.
>>>
>>> So disabling MIPI CAL clock on sensor stream fails is safe.
>>
>> 72us is quite a lot of time, what will happen if LP-11 happens before
>> FSM finished calibration?
>>
>> Maybe the finish_calibration() needs to split into two parts:
>>
>> 1. wait for CAL_STATUS_ACTIVE before enabling sensor
>> 2. wait for CAL_STATUS_DONE after enabling sensor
>
> I don't think we need to split for active and done. Active will be 1 as
> long as other pads are in calibration as well.
>
> We cant use active status check for specific pads under calibration.
> This is common bit for all pads.
Does hardware have a single FSM block shared by all pads or there is FSM
per group of pads?
> Unfortunately HW don't have separate status indicating when sequence is
> done to indicate its waiting for LP11.
>
>
> To avoid all this, will remove cancel_calibration() totally and use same
> finish calibration even in case of stream failure then.
>
What about to add 72us delay to the end of start_calibration() in order
to ensure that FSM is finished before LP-11?
next prev parent reply other threads:[~2020-08-06 16:58 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 15:42 [PATCH v8 00/10] Support for Tegra video capture from external sensor Sowjanya Komatineni
2020-08-03 15:42 ` [PATCH v8 01/10] media: tegra-video: Fix channel format alignment Sowjanya Komatineni
2020-08-03 15:42 ` [PATCH v8 02/10] media: tegra-video: Enable TPG based on kernel config Sowjanya Komatineni
2020-08-03 15:42 ` [PATCH v8 03/10] media: tegra-video: Update format lookup to offset based Sowjanya Komatineni
2020-08-03 15:42 ` [PATCH v8 04/10] dt-bindings: tegra: Update VI and CSI bindings with port info Sowjanya Komatineni
2020-08-03 15:42 ` [PATCH v8 05/10] media: tegra-video: Separate CSI stream enable and disable implementations Sowjanya Komatineni
2020-08-03 15:42 ` [PATCH v8 06/10] media: tegra-video: Add support for external sensor capture Sowjanya Komatineni
2020-08-04 5:57 ` Dmitry Osipenko
2020-08-03 15:42 ` [PATCH v8 07/10] media: tegra-video: Add support for selection ioctl ops Sowjanya Komatineni
2020-08-03 15:42 ` [PATCH v8 08/10] gpu: host1x: mipi: Keep MIPI clock enabled till calibration is done Sowjanya Komatineni
2020-08-05 13:46 ` Thierry Reding
2020-08-05 14:05 ` Dmitry Osipenko
2020-08-05 14:19 ` Dmitry Osipenko
2020-08-05 16:33 ` Sowjanya Komatineni
2020-08-05 16:47 ` Dmitry Osipenko
2020-08-05 16:50 ` Sowjanya Komatineni
2020-08-05 16:57 ` Dmitry Osipenko
2020-08-05 17:04 ` Sowjanya Komatineni
2020-08-05 17:23 ` Dmitry Osipenko
2020-08-05 17:32 ` Sowjanya Komatineni
2020-08-05 17:29 ` Sowjanya Komatineni
2020-08-05 17:34 ` Dmitry Osipenko
2020-08-05 17:46 ` Sowjanya Komatineni
2020-08-05 18:06 ` Sowjanya Komatineni
2020-08-06 0:47 ` Sowjanya Komatineni
2020-08-06 13:32 ` Dmitry Osipenko
2020-08-06 15:59 ` Sowjanya Komatineni
2020-08-06 16:10 ` Dmitry Osipenko [this message]
2020-08-06 16:41 ` Sowjanya Komatineni
2020-08-06 16:45 ` Dmitry Osipenko
2020-08-06 16:51 ` Sowjanya Komatineni
2020-08-06 17:15 ` Dmitry Osipenko
2020-08-06 17:12 ` Sowjanya Komatineni
2020-08-06 17:27 ` Dmitry Osipenko
2020-08-06 17:44 ` Sowjanya Komatineni
2020-08-06 17:52 ` Sowjanya Komatineni
2020-08-06 18:01 ` Dmitry Osipenko
2020-08-06 18:07 ` Sowjanya Komatineni
2020-08-06 18:18 ` Dmitry Osipenko
2020-08-06 18:44 ` Sowjanya Komatineni
2020-08-06 18:51 ` Sowjanya Komatineni
2020-08-06 16:13 ` Dmitry Osipenko
2020-08-06 16:37 ` Dmitry Osipenko
2020-08-06 16:42 ` Sowjanya Komatineni
2020-08-06 16:43 ` Sowjanya Komatineni
2020-08-03 15:42 ` [PATCH v8 09/10] media: tegra-video: Add CSI MIPI pads calibration Sowjanya Komatineni
2020-08-03 15:42 ` [PATCH v8 10/10] media: tegra-video: Compute settle times based on the clock rate Sowjanya Komatineni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5612e93-f1c4-4762-baa1-5d85eb1edbe1@gmail.com \
--to=digetx@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=frankc@nvidia.com \
--cc=gregkh@linuxfoundation.org \
--cc=helen.koike@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=skomatineni@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).