From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89A2DC433FE for ; Wed, 19 Oct 2022 19:12:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231253AbiJSTM2 (ORCPT ); Wed, 19 Oct 2022 15:12:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231146AbiJSTLt (ORCPT ); Wed, 19 Oct 2022 15:11:49 -0400 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94D2C1C9043 for ; Wed, 19 Oct 2022 12:11:43 -0700 (PDT) Received: by mail-pj1-x102b.google.com with SMTP id a5-20020a17090aa50500b002008eeb040eso1428634pjq.1 for ; Wed, 19 Oct 2022 12:11:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yhu8V94jGdFAJfWlKuQJBLxMXBDTgqOAY04Z9XkILB0=; b=WI+E6mdE7KikoyYbx1G5v3rb1cKskrFPEPpUcFSezZZHvmjimQNtiqHHiCfc4pM22J AymUmLfO5HWh/AVsMrYSl5w3Q0rrVH5CxgWqe6ZQxBmHLQykRxTrpcQ0o1fUiTWSrSH0 rlUAd65tlLGEfN/PG8A2OCHLDa9Y8zuGOoBRk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yhu8V94jGdFAJfWlKuQJBLxMXBDTgqOAY04Z9XkILB0=; b=6B9kFS9XZBAk2feLHBZBGBSO53gR57kYg9Iu4Liu1r4j33xVZG0BDMExAfJUhujUJl aadd0AOLPXflRjVgpBybucfXnD1LpoKJ0uxsNKso7tGeAfYPytLmyEULOu6WamyrOws3 9k5RII3SyaLq259PGsswoGmQNkZ0AxTGIB+IRbh8kXPnc7yCxILnxxbLSCBOPYObh66g BH8N4CNESiWDdXjz/ADtQShwZNKEMJBoNRgI/J4PRTNFbzhGLIN87nlNK6EJhT4N7C22 CvFsPZrqpVRTgiDLIjptNGE4QP/LwW43Iy2crwYkGQsU+Eii7N1oXwzcfbVzuBZ8yjk6 /kGQ== X-Gm-Message-State: ACrzQf3vIIPvekzJ+4oMqgAtfD21E6b2GB2hTfQrVZYmfPd4mHYzYIwy CWN+9TnjGCbt7h7B/HICcFtB3g== X-Google-Smtp-Source: AMsMyM4zLj3pDGeqBxExWHkpvRO0zSZiZQezSqyo+Hqz1J5Sd+WMFDOQKLR6oMdA/dpI4i+RVsiYBg== X-Received: by 2002:a17:90b:4b46:b0:20a:e906:426d with SMTP id mi6-20020a17090b4b4600b0020ae906426dmr11831505pjb.48.1666206703114; Wed, 19 Oct 2022 12:11:43 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id b4-20020a170902bd4400b0016d72804664sm11019006plx.205.2022.10.19.12.11.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 12:11:42 -0700 (PDT) Date: Wed, 19 Oct 2022 12:11:41 -0700 From: Kees Cook To: Linus Torvalds Cc: Nick Desaulniers , Segher Boessenkool , "Jason A. Donenfeld" , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-arch@vger.kernel.org, linux-toolchains@vger.kernel.org, Masahiro Yamada , Andrew Morton , Andy Shevchenko , Greg Kroah-Hartman Subject: Re: [PATCH] kbuild: treat char as always signed Message-ID: <202210191209.919149F4@keescook> References: <20221019162648.3557490-1-Jason@zx2c4.com> <20221019165455.GL25951@gate.crashing.org> <20221019174345.GM25951@gate.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-toolchains@vger.kernel.org On Wed, Oct 19, 2022 at 11:56:00AM -0700, Linus Torvalds wrote: > Hundreds and hundreds of that atomic_try_cmpxchg_acquire(), for > example. And they might be trivial to fix (it might be similar to the > fortify-string.h one where it's just a header file that generates most > of them in one single place), but with all the ones that are just > clearly the compiler being silly, they aren't really even worth > looking at. Yeah, I've had to fight these casts in fortify-string.h from time to time. I'd love to see the patch you used -- I bet it would keep future problems at bay. -- Kees Cook