From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A50BC77B73 for ; Tue, 2 May 2023 09:30:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233599AbjEBJaf (ORCPT ); Tue, 2 May 2023 05:30:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233571AbjEBJae (ORCPT ); Tue, 2 May 2023 05:30:34 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63CED4EED for ; Tue, 2 May 2023 02:30:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=bgRKouzMbyJdm28YarCYAl2TwCoDC4ZPtPSVgkPsQ2Q=; b=OCS7qZHjl6ti+eGzj1A0d9ONA+ umTpm+8QfKkEd6wN0pZs8EqZO4kNKhzfac7hvTGsfjeNqSVhepfpX1UOrYV3NIEPt3cpSJnCFYgyA tFexb5wfkUNe1+oDvP1NudVgvvY+uEeCowEzPkw/PKjw8YcKJJ2WMp3DEGXRLbpv40PpcRdwcCkaf tPMbbScpUPkrT5hxaCFS0WUx0qfNYye3GANqwd9/foAVIDP4HUB/zXM37SV+0gs3ITSHoVRffENEf vnf/OG02p3L1FZWo8QXe0uaiEErGrgJcrfZ1c5+KT3fzlR0ixxZ3rLRJ7UVOZXSTTWR7g375S/2xC FHqOrDMg==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1ptmL0-008BEY-Ri; Tue, 02 May 2023 09:30:23 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 65B1A3002BF; Tue, 2 May 2023 11:30:22 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 4E05D23C5C34D; Tue, 2 May 2023 11:30:22 +0200 (CEST) Date: Tue, 2 May 2023 11:30:22 +0200 From: Peter Zijlstra To: Indu Bhagat Cc: linux-toolchains@vger.kernel.org, daandemeyer@meta.com, andrii@kernel.org, rostedt@goodmis.org, kris.van.hees@oracle.com, elena.zannoni@oracle.com, nick.alcock@oracle.com Subject: Re: [POC 3/5] sframe: add new SFrame library Message-ID: <20230502093022.GL1597476@hirez.programming.kicks-ass.net> References: <20230501200410.3973453-1-indu.bhagat@oracle.com> <20230501200410.3973453-4-indu.bhagat@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230501200410.3973453-4-indu.bhagat@oracle.com> Precedence: bulk List-ID: X-Mailing-List: linux-toolchains@vger.kernel.org On Mon, May 01, 2023 at 01:04:08PM -0700, Indu Bhagat wrote: > + /* > + * Skip binary search if FDE sub-section is not sorted on PCs. GNU ld > + * sorts the FDEs on start PC by default though. > + */ > + if ((header->preamble.flags & SFRAME_F_FDE_SORTED) == 0) { > + sframe_set_errno(errp, SFRAME_ERR_FDE_NOTSORTED); > + return NULL; > + } Why does SFrame allow unsorted at all? That seems like a bug in the spec.