Re: [POC 3/5] sframe: add new SFrame library

From: Peter Zijlstra <peterz@infradead.org>
To: Indu Bhagat <indu.bhagat@oracle.com>
Cc: linux-toolchains@vger.kernel.org, daandemeyer@meta.com,
	andrii@kernel.org, rostedt@goodmis.org, kris.van.hees@oracle.com,
	elena.zannoni@oracle.com, nick.alcock@oracle.com
Subject: Re: [POC 3/5] sframe: add new SFrame library
Date: Tue, 2 May 2023 12:41:25 +0200	[thread overview]
Message-ID: <20230502104125.GN1597476@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20230501200410.3973453-4-indu.bhagat@oracle.com>

On Mon, May 01, 2023 at 01:04:08PM -0700, Indu Bhagat wrote:
> +/* SFrame FRE types. */
> +#define SFRAME_FRE_TYPE_ADDR1	0
> +#define SFRAME_FRE_TYPE_ADDR2	1
> +#define SFRAME_FRE_TYPE_ADDR4	2

> +static size_t sframe_fre_get_start_address_tsize(unsigned int fre_type)

That name is just amazing :/

> +{
> +	/* Type size of the start_addr in an FRE. */
> +	size_t saddr_tsize = 0;
> +
> +	switch (fre_type) {
> +	case SFRAME_FRE_TYPE_ADDR1:
> +		saddr_tsize = sizeof(uint8_t);
> +		break;
> +	case SFRAME_FRE_TYPE_ADDR2:
> +		saddr_tsize = sizeof(uint16_t);
> +		break;
> +	case SFRAME_FRE_TYPE_ADDR4:
> +		saddr_tsize = sizeof(uint32_t);
> +		break;
> +	default:
> +		/* No other value is expected. */
> +		break;
> +	}
> +	return saddr_tsize;

	return 1 << fre_type;

was too complicated?

> +}